Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connectivity: Add OpenAI and Databricks Private Link DNS #918

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

nyanhp
Copy link

@nyanhp nyanhp commented Mar 28, 2024

Overview/Summary

This PR fixes #890 by adding the OpenAI and Databricks Private Link DNS zones.

This PR fixes/adds/changes/removes

  1. feat: private DNS zone for OpenAI.  #890

Breaking Changes

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

Add OpenAI Private Link
@glloyd2010f
Copy link

glloyd2010f commented May 8, 2024

Back seat quarterback here, but is there any objection to adding scm.privatelink.azurewebsites.net as well? Based on the code it should just require updating the azure_web_apps_sites array within the terraform-azurerm-caf-enterprise-scale\modules\connectivity\locals.tf to include the new zone.

@tlfzhylj
Copy link

Any chance for this to be completed?
This will also fix #851

Copy link

@tlfzhylj tlfzhylj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a search for another one of the private DNS zones, and it looks like they are referenced several places.

Example: https://github.com/search?q=repo%3AAzure%2Fterraform-azurerm-caf-enterprise-scale%20azure_database_for_postgresql_server&type=code

@matt-FFFFFF matt-FFFFFF changed the base branch from main to feat/ama June 6, 2024 17:25
@matt-FFFFFF matt-FFFFFF merged commit 09a4211 into Azure:feat/ama Jun 6, 2024
2 checks passed
@matt-FFFFFF matt-FFFFFF mentioned this pull request Jun 6, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: private DNS zone for OpenAI.
4 participants