Change identity_ids type to Set

Azure · Dec 2, 2024 · ef53b15 · ef53b15
1 parent c95c788
commit ef53b15
Show file tree

Hide file tree

Showing 27 changed files with 1,606 additions and 7 deletions.
diff --git a/docs/data-sources/resource.md b/docs/data-sources/resource.md
@@ -160,7 +160,7 @@ Optional:
 
 Read-Only:
 
-- `identity_ids` (List of String) A list of User Managed Identity ID's which should be assigned to the azure resource.
+- `identity_ids` (Set of String) A set of User Managed Identity ID's which should be assigned to the azure resource.
 - `principal_id` (String) The Principal ID for the Service Principal associated with the Managed Service Identity of this Azure resource.
 - `tenant_id` (String) The Tenant ID for the Service Principal associated with the Managed Service Identity of this Azure resource.
 - `type` (String) The Type of Identity which should be used for this azure resource. Possible values are `SystemAssigned`, `UserAssigned` and `SystemAssigned,UserAssigned`
diff --git a/docs/resources/resource.md b/docs/resources/resource.md
@@ -195,7 +195,7 @@ Required:
 
 Optional:
 
-- `identity_ids` (List of String) A list of User Managed Identity ID's which should be assigned to the azure resource.
+- `identity_ids` (Set of String) A set of User Managed Identity ID's which should be assigned to the azure resource.
 
 Read-Only:
 

diff --git a/internal/docstrings/identity_ids.go b/internal/docstrings/identity_ids.go
@@ -1,7 +1,7 @@
 package docstrings
 
 const (
-	identityIds = `A list of User Managed Identity ID's which should be assigned to the azure resource.`
+	identityIds = `A set of User Managed Identity ID's which should be assigned to the azure resource.`
 )
 
 // IdentityIds returns the docstring for the identity type attribute.

diff --git a/internal/services/azapi_resource.go b/internal/services/azapi_resource.go
@@ -32,6 +32,7 @@ import (
 	"github.com/cenkalti/backoff/v4"
 	"github.com/hashicorp/terraform-plugin-framework-timeouts/resource/timeouts"
 	"github.com/hashicorp/terraform-plugin-framework-validators/listvalidator"
+	"github.com/hashicorp/terraform-plugin-framework-validators/setvalidator"
 	"github.com/hashicorp/terraform-plugin-framework-validators/stringvalidator"
 	"github.com/hashicorp/terraform-plugin-framework/attr"
 	"github.com/hashicorp/terraform-plugin-framework/diag"
@@ -338,11 +339,11 @@ func (r *AzapiResource) Schema(ctx context.Context, _ resource.SchemaRequest, re
 							MarkdownDescription: docstrings.IdentityType(),
 						},
 
-						"identity_ids": schema.ListAttribute{
+						"identity_ids": schema.SetAttribute{
 							ElementType: types.StringType,
 							Optional:    true,
-							Validators: []validator.List{
-								listvalidator.ValueStringsAre(myvalidator.StringIsUserAssignedIdentityID()),
+							Validators: []validator.Set{
+								setvalidator.ValueStringsAre(myvalidator.StringIsUserAssignedIdentityID()),
 							},
 							MarkdownDescription: docstrings.IdentityIds(),
 						},

diff --git a/internal/services/azapi_resource_data_source.go b/internal/services/azapi_resource_data_source.go
@@ -126,7 +126,7 @@ func (r *AzapiResourceDataSource) Schema(ctx context.Context, request datasource
 							MarkdownDescription: docstrings.IdentityTenantID(),
 						},
 
-						"identity_ids": schema.ListAttribute{
+						"identity_ids": schema.SetAttribute{
 							Computed:            true,
 							ElementType:         types.StringType,
 							MarkdownDescription: docstrings.IdentityIds(),

diff --git a/vendor/github.com/hashicorp/terraform-plugin-framework-validators/setvalidator/all.go b/vendor/github.com/hashicorp/terraform-plugin-framework-validators/setvalidator/all.go
diff --git a/.../github.com/hashicorp/terraform-plugin-framework-validators/setvalidator/also_requires.go b/.../github.com/hashicorp/terraform-plugin-framework-validators/setvalidator/also_requires.go
diff --git a/vendor/github.com/hashicorp/terraform-plugin-framework-validators/setvalidator/any.go b/vendor/github.com/hashicorp/terraform-plugin-framework-validators/setvalidator/any.go
diff --git a/...com/hashicorp/terraform-plugin-framework-validators/setvalidator/any_with_all_warnings.go b/...com/hashicorp/terraform-plugin-framework-validators/setvalidator/any_with_all_warnings.go
diff --git a/...ithub.com/hashicorp/terraform-plugin-framework-validators/setvalidator/at_least_one_of.go b/...ithub.com/hashicorp/terraform-plugin-framework-validators/setvalidator/at_least_one_of.go
diff --git a/...github.com/hashicorp/terraform-plugin-framework-validators/setvalidator/conflicts_with.go b/...github.com/hashicorp/terraform-plugin-framework-validators/setvalidator/conflicts_with.go
diff --git a/vendor/github.com/hashicorp/terraform-plugin-framework-validators/setvalidator/doc.go b/vendor/github.com/hashicorp/terraform-plugin-framework-validators/setvalidator/doc.go
diff --git a/...github.com/hashicorp/terraform-plugin-framework-validators/setvalidator/exactly_one_of.go b/...github.com/hashicorp/terraform-plugin-framework-validators/setvalidator/exactly_one_of.go