Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azapi_resource_action - support sensitive_response_export_values and sensitive_output fields #718

Merged
merged 5 commits into from
Jan 16, 2025

Conversation

ms-henglu
Copy link
Member

fixes #707

@matt-FFFFFF
Copy link
Member

Hi @ms-henglu do you think this could be in place for azapi_resource as well?

internal/docstrings/output.go Outdated Show resolved Hide resolved
internal/docstrings/output.go Outdated Show resolved Hide resolved
@ms-henglu
Copy link
Member Author

Hi @matt-FFFFFF ,

Thanks for the code review!

I think it's not necessary to add it in the azapi_resource, because azapi_resource only calls GET to the resource, and GET response should not contain sensitive values.

@ms-henglu ms-henglu requested review from matt-FFFFFF and magodo and removed request for matt-FFFFFF January 13, 2025 02:47
@ms-henglu ms-henglu merged commit 327514e into main Jan 16, 2025
10 checks passed
@ms-henglu ms-henglu deleted the issue-707 branch January 16, 2025 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: consider adding sensitive_response_export_values
3 participants