Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFNFR25 - Category: Code Style - Terraform block version requirements #22

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

lonegunmanb
Copy link
Member

required_version = "~> 1.7.0"
required_providers {
azurerm = {
version = ">= 3.98.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that version should be like "~> #.#" or ">= #.#, < #.#". Please also update others with same problem.

required_version = "~> 1.7.0"
required_providers {
azurerm = {
version = ">= 3.98.0"
Copy link
Contributor

@neil-yechenwei neil-yechenwei Apr 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the order. I assume the order should be like below this. Please also update others with same problem.

azurerm = {
source = "hashicorp/azurerm"
version = ">= 3.97.0, < 3.99.0"
}

package rules_test

import (
"github.com/Azure/tflint-ruleset-avm/rules"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sort the order. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants