Additional WAF tflint rules

waf/azurerm_app_service_plan.go

@@ -0,0 +1,14 @@
+package waf
+
+import "github.com/Azure/tflint-ruleset-avm/attrvalue"
+
+func (wf WafRules) AzurermAppServicePlanZoneRedundant() *attrvalue.SimpleRule[bool] {
+	return attrvalue.NewSimpleRule[bool](
+		"azurerm_app_service_plan",
+		"zone_redundant",
+		[]bool{true},
+		"https://learn.microsoft.com/en-us/azure/reliability/reliability-app-service?tabs=cli#-asp-2--use-an-app-service-plan-that-supports-availability-zones",
+		false,
+		"",
+	)
+}

waf/azurerm_cosmosdb_account.go

@@ -15,3 +15,15 @@ func (wf WafRules) AzurermCosmosDbAccountBackupMode() *attrvalue.SimpleRule[stri
 		"",
 	)
 }
+
+func (wf WafRules) AzurermCosmosDbAccountFailoverEnabled() *attrvalue.SimpleRule[bool] {
+	return attrvalue.NewSimpleRule[bool](
+		"azurerm_cosmosdb_account",
+		"automatic_failover_enabled",
+		[]bool{true},
+		"https://azure.github.io/Azure-Proactive-Resiliency-Library-v2/azure-resources/ContainerService/managedClusters/#enable-the-cluster-auto-scaler-on-an-existing-cluster",
+		false,
+		"",
+	)
+}
+

waf/azurerm_kubernetes_cluster.go

@@ -11,3 +11,35 @@ func (wf WafRules) AzurermKubernetesClusterZones() *attrvalue.SetRule[int] {
 		"",
 	)
 }
+
+func (wf WafRules) AzurermKubernetesClusterSkuTier() *attrvalue.SimpleRule[string] {
+	return attrvalue.NewSimpleRule[string](
+		"azurerm_kubernetes_cluster",
+		"sku_tier",
+		[]string{"Standard", "Premium"},
+		"https://azure.github.io/Azure-Proactive-Resiliency-Library-v2/azure-resources/ContainerService/managedClusters/#update-aks-tier-to-standard",
+		false,
+		"",
+	)
+}
+
+func (wf WafRules) AzurermKubernetesClusterAutoScalingEnabled() *attrvalue.SimpleRule[bool] {
+	return attrvalue.NewSimpleRule[bool](
+		"azurerm_kubernetes_cluster",
+		"auto_scaling_enabled",
+		[]bool{true},
+		"https://azure.github.io/Azure-Proactive-Resiliency-Library-v2/azure-resources/ContainerService/managedClusters/#enable-the-cluster-auto-scaler-on-an-existing-cluster",
+		false,
+		"",
+	)
+}
+
+func (wf WafRules) AzurermKubernetesClusterOMSAgentUnconfigured() *attrvalue.UnknownValueRule {
+	return attrvalue.NewUnknownValueNestedBlockRule(
+		"azurerm_kubernetes_cluster",
+		"oms_agent",
+		"log_analytics_workspace_id",
+		"https://azure.github.io/Azure-Proactive-Resiliency-Library-v2/azure-resources/Compute/virtualMachines/#deploy-vms-across-availability-zones",
+		"",
+	)
+}

waf/azurerm_kubernetes_cluster_node_pool

@@ -0,0 +1,4 @@
+package waf
+
+import "github.com/Azure/tflint-ruleset-avm/attrvalue"
+

waf/azurerm_maintenance_assignment_virtual_machine.go

@@ -0,0 +1,21 @@
+package waf
+
+import "github.com/Azure/tflint-ruleset-avm/attrvalue"
+
+func (wf WafRules) AzurermVirtualMachineUseMaintenanceConfiguration1() *attrvalue.UnknownValueRule {
+	return attrvalue.NewUnknownValueRule(
+		"azurerm_maintenance_assignment_virtual_machine",
+		"maintenance_configuration_id",
+		"https://azure.github.io/Azure-Proactive-Resiliency-Library-v2/azure-resources/Compute/virtualMachines/#use-maintenance-configurations-for-the-vms",
+		"",
+	)
+}
+
+func (wf WafRules) AzurermVirtualMachineUseMaintenanceConfiguration2() *attrvalue.UnknownValueRule {
+	return attrvalue.NewUnknownValueRule(
+		"azurerm_maintenance_assignment_virtual_machine",
+		"virtual_machine_id",
+		"https://azure.github.io/Azure-Proactive-Resiliency-Library-v2/azure-resources/Compute/virtualMachines/#use-maintenance-configurations-for-the-vms",
+		"",
+	)
+}

waf/azurerm_managed_disk.go

@@ -0,0 +1,16 @@
+package waf
+
+import (
+	"github.com/Azure/tflint-ruleset-avm/attrvalue"
+)
+
+func (wf WafRules) AzurermManagedDiskStorageAccountTypeIsZRS() *attrvalue.SimpleRule[string] {
+	return attrvalue.NewSimpleRule[string](
+		"azurerm_amanaged_disk",
+		"sku",
+		[]string{"StandardSSD_ZRS", "Premium_ZRS"},
+		"https://azure.github.io/Azure-Proactive-Resiliency-Library-v2/welcome/",
+		false,
+		"",
+	)
+}

waf/azurerm_redis_cache.go

@@ -0,0 +1,15 @@
+package waf
+
+import (
+	"github.com/Azure/tflint-ruleset-avm/attrvalue"
+)
+
+func (wf WafRules) AzurermRedisCacheZoneRedundancyEnabled() *attrvalue.SetRule[int] {
+	return attrvalue.NewSetRule(
+		"azurerm_redis_cache",
+		"zones",
+		[][]int{{1, 2, 3}},
+		"https://azure.github.io/Azure-Proactive-Resiliency-Library-v2/azure-resources/Cache/Redis/#enable-zone-redundancy-for-azure-cache-for-redis",
+		"",
+	)
+}

waf/azurerm_virtual_machine.go

@@ -6,7 +6,7 @@ func (wf WafRules) AzurermVirtualMachineZoneUnknown() *attrvalue.UnknownValueRul
 	return attrvalue.NewUnknownValueRule(
 		"azurerm_virtual_machine",
 		"zone",
-		"https://azure.github.io/Azure-Proactive-Resiliency-Library/services/compute/virtual-machines/#vm-2---deploy-vms-across-availability-zones",
+		"https://azure.github.io/Azure-Proactive-Resiliency-Library-v2/azure-resources/Compute/virtualMachines/#deploy-vms-across-availability-zones",
 		"",
 	)
 }
@@ -15,7 +15,7 @@ func (wf WafRules) AzurermVirtualMachineZonesUnknown() *attrvalue.UnknownValueRu
 	return attrvalue.NewUnknownValueRule(
 		"azurerm_virtual_machine",
 		"zones",
-		"https://azure.github.io/Azure-Proactive-Resiliency-Library/services/compute/virtual-machines/#vm-2---deploy-vms-across-availability-zones",
+		"https://azure.github.io/Azure-Proactive-Resiliency-Library-v2/azure-resources/Compute/virtualMachines/#deploy-vms-across-availability-zones",
 		"",
 	)
 }