Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TCGC][Bug] TCGC added content-type header should be optional if request body is optional #1259

Closed
Tracked by #2665
, #2930 ,  #2931
...
haolingdong-msft opened this issue Jul 30, 2024 · 0 comments · Fixed by #1452
Closed
Tracked by #2665
, #2930 ,  #2931
...

[TCGC][Bug] TCGC added content-type header should be optional if request body is optional #1259

haolingdong-msft opened this issue Jul 30, 2024 · 0 comments · Fixed by #1452
Assignees
@haolingdong-msft
Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library

Comments

@haolingdong-msft
Copy link
Member

haolingdong-msft commented Jul 30, 2024 •
edited
Loading

Currently if the operation's request body is optional, TCGC will still add a required content-type header, this seems incorrect. Because for this case, we don't want to add content-type by default. It should be added when body is passed in. So we need to mark the content-type as optional.

image
@haolingdong-msft haolingdong-msft changed the title [TCGC][Bug] TCGC added content-type [TCGC][Bug] TCGC added content-type header should be optional if request body is optional Jul 30, 2024
@haolingdong-msft haolingdong-msft self-assigned this Jul 30, 2024
@haolingdong-msft haolingdong-msft mentioned this issue Jul 30, 2024
Closed
@lirenhe lirenhe added the lib:tcgc Issues for @azure-tools/typespec-client-generator-core library label Aug 12, 2024
@haolingdong-msft haolingdong-msft mentioned this issue Aug 21, 2024
Open
@haolingdong-msft haolingdong-msft mentioned this issue Aug 30, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 2, 2024
@haolingdong-msft
TCGC, make content type optional when request body is optional (#1452)
d9b2b5d 
Fix #1259
markcowl pushed a commit to markcowl/typespec-azure that referenced this issue Sep 7, 2024
@haolingdong-msft @markcowl
TCGC, make content type optional when request body is optional (Azure…
a990d22 
…#1452)

Fix Azure#1259
@jhendrixMSFT jhendrixMSFT mentioned this issue Oct 18, 2024
Closed
@haolingdong-msft haolingdong-msft mentioned this issue Nov 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haolingdong-msft haolingdong-msft

Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TCGC, make content type optional when request body is optional haolingdong-msft/typespec-azure
2 participants
@lirenhe @haolingdong-msft