Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ruleset naming #330

Closed
timotheeguerin opened this issue Feb 28, 2024 · 2 comments · Fixed by #927
Closed

Update ruleset naming #330

timotheeguerin opened this issue Feb 28, 2024 · 2 comments · Fixed by #927
Assignees
@timotheeguerin
Labels
breaking-change A change that might cause specs or code to break design:accepted Proposal for design has been discussed and accepted.
Milestone
[2024] July

Comments

@timotheeguerin
Copy link
Member

timotheeguerin commented Feb 28, 2024 •
edited
Loading

Problem is we have use /all as the only ruleset we had in azure-core and arm.

However this is confusing as with the addition of cannonical ruleset all isn't actually all its more required.

Proposing we change to the following:

  • all (Actually every single rule)
  • required or recommended (Only required rules)
  • <any-optional-ruleset>

This of course would need some change in the tspconfig validation of the spec repos as well as replacing.
@timotheeguerin timotheeguerin mentioned this issue Feb 28, 2024
Merged
@markcowl markcowl added the breaking-change A change that might cause specs or code to break label Mar 5, 2024
@markcowl markcowl added this to the [2024] April milestone Mar 5, 2024
@markcowl markcowl added the design:needed A design request has been raised that needs a proposal label Mar 5, 2024
@markcowl markcowl modified the milestones: [2024] April, [2024] May Apr 8, 2024
@markcowl markcowl added design:accepted Proposal for design has been discussed and accepted. and removed design:needed A design request has been raised that needs a proposal needs-area labels Apr 10, 2024
@markcowl markcowl modified the milestones: [2024] May, [2024] June May 7, 2024
@timotheeguerin
Copy link
Member Author

timotheeguerin commented May 17, 2024 •
edited
Loading

Should be done after this has been rollout #654

@timotheeguerin timotheeguerin mentioned this issue May 28, 2024
Merged
@timotheeguerin
Copy link
Member Author

#654 is done, made a pr to automatically generate the all ruleset microsoft/typespec#3462 after this is merged we can remove all the explicit all rulesets and that will respect the established rules

@timotheeguerin timotheeguerin self-assigned this May 28, 2024
@timotheeguerin timotheeguerin mentioned this issue May 28, 2024
Merged
github-merge-queue bot pushed a commit to microsoft/typespec that referenced this issue Jun 3, 2024
@timotheeguerin
Linter all rulesets automatically created (#3462)
5da8fe7 
Provide a built in way for
Azure/typespec-azure#330
@tjprescott tjprescott changed the title Consider changing the ruleset naming Update ruleset naming Jun 6, 2024
@markcowl markcowl modified the milestones: [2024] June, [2024] July Jun 17, 2024
@timotheeguerin timotheeguerin self-assigned this Jul 3, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 16, 2024
@timotheeguerin @markcowl
Remove all rulesets (#927)
45b425f 
fix [#330](#330)

`all` rulesets are automaticlaly provided by the compiler now
microsoft/typespec#3462

---------

Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timotheeguerin timotheeguerin

Labels
breaking-change A change that might cause specs or code to break design:accepted Proposal for design has been discussed and accepted.
Projects
None yet
Milestone
[2024] July
Development

Successfully merging a pull request may close this issue.

Remove all rulesets timotheeguerin/typespec-azure
2 participants
@timotheeguerin @markcowl