Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCGC, SdkClientType.crossLanguageDefinitionId is missing #954

Closed
Tracked by #2665
haolingdong-msft opened this issue Jun 5, 2024 · 0 comments · Fixed by #1238
Closed
Tracked by #2665

TCGC, SdkClientType.crossLanguageDefinitionId is missing #954

haolingdong-msft opened this issue Jun 5, 2024 · 0 comments · Fixed by #1238
Assignees
Labels
bug Something isn't working lib:tcgc Issues for @azure-tools/typespec-client-generator-core library

Comments

@haolingdong-msft
Copy link
Member

haolingdong-msft commented Jun 5, 2024

SdkClient has property crossLanguageDefinitionId, but the new SdkClientType does not have this property.
We should add this information to SdkClientType.

export interface SdkClientType<TServiceOperation extends SdkServiceOperation> {
    kind: "client";
    name: string;
    description?: string;
    details?: string;
    initialization: SdkInitializationType;
    methods: SdkMethod<TServiceOperation>[];
    apiVersions: string[];
    nameSpace: string;
    /**
     * @deprecated This property is deprecated. Look at `.arm` on `SdkContext` instead.
     */
    arm: boolean;
}

export interface SdkClient {
    kind: "SdkClient";
    name: string;
    service: Namespace;
    type: Namespace | Interface;
    /**
     * @deprecated This property is deprecated. Look at `.arm` on `SdkContext` instead.
     */
    arm: boolean;
    crossLanguageDefinitionId: string;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants