-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix when rendering version enum only include current member and mark it modelAsString: true #923
Fix when rendering version enum only include current member and mark it modelAsString: true #923
Conversation
All changed packages have been documented.
Show changes
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/923/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/923/ |
#1 is good |
Further thinking about it, swaggers/openapi, it only represent one version in our multi-version to single-version emission, it is accurate to render single version there. So I am good with this change. |
So this only applies if you reference the version enum in other cases we already omitted it. In those case the only real case is when it's used in the paramerrized host. I don't think it matters at all what that value is as it's not used in swagger generators but only selecting the current version does feel right and the simplest so we don't create extra diff for new versions |
This ensure that when the version enum is still referenced that