Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tcgc] update crossLanguageDefinitionId to correspond to apiview #936

Merged
merged 9 commits into from
Jun 3, 2024
Merged

[tcgc] update crossLanguageDefinitionId to correspond to apiview #936

merged 9 commits into from
Jun 3, 2024

Conversation

iscai-msft
Copy link
Contributor

@iscai-msft iscai-msft commented May 29, 2024 •
edited
Loading

fixes #849

@microsoft-github-policy-service microsoft-github-policy-service bot added the lib:tcgc Issues for @azure-tools/typespec-client-generator-core library label May 29, 2024
@iscai-msft iscai-msft requested a review from tjprescott May 29, 2024 22:35
@azure-sdk
Copy link
Collaborator

azure-sdk commented May 30, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @azure-tools/typespec-client-generator-core
Show changes

@azure-tools/typespec-client-generator-core - fix ✏️

enhance cross language definition id logic

@azure-sdk
Copy link
Collaborator

You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/936/

Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/936/

tjprescott
tjprescott reviewed Jun 3, 2024
View reviewed changes
Copy link
Member

@tjprescott tjprescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments.

packages/typespec-client-generator-core/test/public-utils.test.ts Show resolved Hide resolved
packages/typespec-client-generator-core/test/package.test.ts Show resolved Hide resolved
packages/typespec-client-generator-core/test/package.test.ts Show resolved Hide resolved
@iscai-msft iscai-msft enabled auto-merge June 3, 2024 17:59
@iscai-msft iscai-msft added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit 3af118a Jun 3, 2024
21 checks passed
@iscai-msft iscai-msft deleted the tsp_clid branch June 3, 2024 19:30
This was referenced Jul 5, 2024
Closed
Merged
This was referenced Jul 20, 2024
Open
Merged
This was referenced Jul 28, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjprescott tjprescott tjprescott approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel is a code owner

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

Assignees
No one assigned
Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: TCGC generates incorrect cross-language definition IDs
4 participants
@iscai-msft @azure-sdk @tjprescott @tadelesh