Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AKS Welcome page ALWAYS opens #930

Closed
Jaykul opened this issue Sep 19, 2024 · 2 comments · Fixed by #931
Closed

AKS Welcome page ALWAYS opens #930

Jaykul opened this issue Sep 19, 2024 · 2 comments · Fixed by #931
Assignees
Labels
bug Something isn't working triage

Comments

@Jaykul
Copy link

Jaykul commented Sep 19, 2024

Describe the bug

The AKS Extension (unlike any other extension I've used) keeps showing the welcome page every time I open VS Code, or open a new folder, regardless of the fact that there's no new news, and everything in there has been marked "Done".

After the first dozen times a day it's actually quite annoying. See also:

Mention the platform you are using

VSCode, Windows

To Reproduce
Steps to reproduce the behavior:

  1. Install AKS Extension in VSCode
  2. Open VS Code ("Welcome" shows)
    image
  3. Mark everything done ...
  4. Open VS Code ("Welcome" still shows)
  5. Click to mark everything done ... again
  6. Disable "Welcome" globally
    image
  7. Open VS Code ("Welcome" still shows)

Expected behavior

  1. Welcome pages should only show if I have "Show welcome page on startup"
  2. Extension-specific welcome pages should only show if there's new information that's not marked done
  3. Extension should register it's "Welcome" page in the command palette so I can open it later myself

Desktop (please complete the following information):

  • OS: Windows
  • Browser: Firefox
@Tatsinnit
Copy link
Member

Thank you so much for reporting this, really appreciate it! We've added a fix for this, and once tested and merged it will be part of next release. Thanks. Thank you so much for repro @ReinierCC for testing as well.

@Tatsinnit Tatsinnit added the bug Something isn't working label Sep 19, 2024
@Tatsinnit Tatsinnit linked a pull request Sep 19, 2024 that will close this issue
@Tatsinnit
Copy link
Member

💡A quick loop back, post release: the fix for this is released under version 1.4.10 thank you so much for this. ❤️ 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants