Fix for walkthrough and show welcome dependency. #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tatsinnit
added
bug
Tatsinnit
requested review from
qpetraroia,
ReinierCC,
tejhan and
hsubramanianaks
ReinierCC
approved these changes
Sep 20, 2024
tejhan
approved these changes
Sep 20, 2024
tejhan
pushed a commit
to tejhan/vscode-aks-tools
that referenced
this pull request
Dec 4, 2024
Co-authored-by: Tatsat Mishra <tatsat.mishra@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is purely for the aspect of things which leads to the fixing #930 Now once user select the aka uncheck
show welcome pagethe walk thought will not show up.because upon uncheck the property in workspace gets set like this, and we are making sure walkthrough is not called until that is set. Thank you so much @ReinierCC for testing and fyi/collab. <3
VSIX for testing:
vscode-aks-tools-1.4.9-fixwalkthrough.vsix.zip
This one is proper zip file so unzip and then use the vsix under that to install.
Uploading vscode-aks-tools-1.4.9-fixwalkthrough.vsix.zip…