Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obsolete int claims, add long claims #2283

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Obsolete int claims, add long claims #2283

merged 1 commit into from
Sep 5, 2023

Conversation

westin-m
Copy link
Contributor

Addresses #2266

@westin-m westin-m linked an issue Aug 30, 2023 that may be closed by this pull request
[Feature Request] Deprecate int? JwtPayload.Exp, .Iat, .Nbf #2266
Closed
@jennyf19 jennyf19 added this to the 7.0.0-preview5 milestone Sep 5, 2023
@westin-m westin-m enabled auto-merge September 5, 2023 16:40
@sruke
Copy link
Contributor

sruke commented Sep 5, 2023 •
edited
Loading

Should EpochTime class support representing DateTime in long? It currently supports int.

See

azure-activedirectory-identitymodel-extensions-for-dotnet/src/System.IdentityModel.Tokens.Jwt/JwtPayload.cs

Line 118 in 3ef57d9

this[JwtRegisteredClaimNames.Nbf] = EpochTime.GetIntDate(notBefore.Value.ToUniversalTime());
where DateTime is being read as an int.

EpochTime:

azure-activedirectory-identitymodel-extensions-for-dotnet/src/Microsoft.IdentityModel.Tokens/EpochTime.cs

Line 25 in 2cf0feb

public static long GetIntDate(DateTime datetime)
"

@brentschmaltz
Copy link
Member

@sruke EpochTime.GetIntDate returns a long.

@westin-m westin-m added this pull request to the merge queue Sep 5, 2023
Merged via the queue into dev7 with commit b57863b Sep 5, 2023
eerhardt added a commit to eerhardt/aspnetcore that referenced this pull request Sep 6, 2023
@eerhardt
Update test to account for bug fix in AzureAD/azure-activedirectory-i…
f8b011a 
…dentitymodel-extensions-for-dotnet#2283.
@eerhardt eerhardt mentioned this pull request Sep 6, 2023
Merged
brentschmaltz pushed a commit that referenced this pull request Sep 6, 2023
@westin-m
obsolete int claims (#2283)
2443659
brentschmaltz pushed a commit that referenced this pull request Sep 7, 2023
@westin-m @brentschmaltz
obsolete int claims (#2283)
ef13491
mkArtakMSFT pushed a commit to dotnet/aspnetcore that referenced this pull request Sep 7, 2023
@eerhardt @dotnet-maestro
Update Microsoft.IdentityModel to 7.0.0-preview5 (#50538)
f8cdb58 
* Update Microsoft.IdentityModel to 7.0.0-preview

* Update test to account for bug fix in AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet#2283.

* Update dependencies from https://github.com/dotnet/source-build-externals build 20230906.1

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 8.0.0-alpha.1.23455.1 -> To Version 8.0.0-alpha.1.23456.1

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@westin-m westin-m deleted the westinm/epochTimeUpdate branch September 11, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sruke sruke sruke approved these changes

@brentschmaltz brentschmaltz brentschmaltz approved these changes

@jennyf19 jennyf19 Awaiting requested review from jennyf19

@jmprieur jmprieur Awaiting requested review from jmprieur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0-preview5
Development

Successfully merging this pull request may close these issues.

[Feature Request] Deprecate int? JwtPayload.Exp, .Iat, .Nbf
5 participants
@westin-m @sruke @brentschmaltz @jmprieur @jennyf19