Use new Base64Url API #2817
Merged
Use new Base64Url API #2817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@msbw2 Can you post a before / after of this benchmark as well here: JsonWebTokenHandler_ValidateTokenAsyncWithTVP ? Would be good to see the difference at that level. |
msbw2
force-pushed
the
brettwhite/base64url
branch
5 times, most recently
from
4abfe06 to
9b9b583
Compare
src/Microsoft.IdentityModel.Tokens/Microsoft.IdentityModel.Tokens.csproj
Outdated
Show resolved
Hide resolved
Benchmarks are here: #2828 (comment) |
pmaytak
requested changes
Sep 20, 2024
msbw2
force-pushed
the
brettwhite/base64url
branch
from
9b9b583 to
615df8a
Compare
jennyf19
reviewed
Sep 20, 2024
msbw2
force-pushed
the
brettwhite/base64url
branch
2 times, most recently
from
9e2ff23 to
b1d4eed
Compare
pmaytak
reviewed
Sep 20, 2024
benchmark/Microsoft.IdentityModel.Benchmarks/identitymodel.benchmarks.yml
Outdated
Show resolved
Hide resolved
msbw2
force-pushed
the
brettwhite/base64url
branch
2 times, most recently
from
168bfe8 to
08c0f25
Compare
msbw2
force-pushed
the
brettwhite/base64url
branch
6 times, most recently
from
73666d5 to
55946bb
Compare
pmaytak
reviewed
Sep 23, 2024
test/Microsoft.IdentityModel.Tokens.Tests/Base64UrlEncodingTests.cs
Outdated
Show resolved
Hide resolved
msbw2
force-pushed
the
brettwhite/base64url
branch
from
55946bb to
4ddc291
Compare
This was referenced Aug 7, 2025
Bump Microsoft.IdentityModel.Protocols.OpenIdConnect from 8.0.1 to 8.13.0
statisticssweden/PxWeb#693
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new
Base64UrlAPI.