Disable Network check by default #2480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamgusain
reviewed
Aug 16, 2024
.../src/main/java/com/microsoft/identity/common/adal/internal/net/DefaultConnectionService.java
Outdated
Show resolved
Hide resolved
iamgusain
approved these changes
Aug 16, 2024
melissaahn
approved these changes
Aug 16, 2024
melissaahn
reviewed
Aug 16, 2024
common4j/src/main/com/microsoft/identity/common/java/flighting/CommonFlight.java
Outdated
Show resolved
Hide resolved
shahzaibj
approved these changes
Aug 16, 2024
rpdome
added a commit
that referenced
this pull request
Aug 19, 2024
This "test" is not reliable. (a handful of broker requests failed with this check, but then succeeded with OneAuth.) This PR will disable the test by default - bringing the behavior in BOTH Broker and Common to match with OneAuth's. --- NOTE: [Doze mode network check](https://github.com/AzureAD/microsoft-authentication-library-common-for-android/blob/3bd7337d4bc0df4974cc30701b22a43b3a4d8059/common/src/main/java/com/microsoft/identity/common/internal/platform/AndroidPlatformUtil.java#L122) is not in scope of this work. (that check is set by SDK. - In MSAL, that's true by default (via MSAL config). - In OneAuth, it's always false. There's no way for an app to set, and OneAuth never touches it). # Conflicts: # changelog.txt # common4j/src/main/com/microsoft/identity/common/java/flighting/CommonFlight.java
rpdome
added a commit
that referenced
this pull request
Sep 12, 2024
This "test" is not reliable. (a handful of broker requests failed with this check, but then succeeded with OneAuth.) This PR will disable the test by default - bringing the behavior in BOTH Broker and Common to match with OneAuth's. --- NOTE: [Doze mode network check](https://github.com/AzureAD/microsoft-authentication-library-common-for-android/blob/3bd7337d4bc0df4974cc30701b22a43b3a4d8059/common/src/main/java/com/microsoft/identity/common/internal/platform/AndroidPlatformUtil.java#L122) is not in scope of this work. (that check is set by SDK. - In MSAL, that's true by default (via MSAL config). - In OneAuth, it's always false. There's no way for an app to set, and OneAuth never touches it). # Conflicts: # changelog.txt # common4j/src/main/com/microsoft/identity/common/java/flighting/CommonFlight.java
rpdome
added a commit
that referenced
this pull request
Sep 13, 2024
This "test" is not reliable. (a handful of broker requests failed with this check, but then succeeded with OneAuth.) This PR will disable the test by default - bringing the behavior in BOTH Broker and Common to match with OneAuth's. --- NOTE: [Doze mode network check](https://github.com/AzureAD/microsoft-authentication-library-common-for-android/blob/3bd7337d4bc0df4974cc30701b22a43b3a4d8059/common/src/main/java/com/microsoft/identity/common/internal/platform/AndroidPlatformUtil.java#L122) is not in scope of this work. (that check is set by SDK. - In MSAL, that's true by default (via MSAL config). - In OneAuth, it's always false. There's no way for an app to set, and OneAuth never touches it). # Conflicts: # changelog.txt # common4j/src/main/com/microsoft/identity/common/java/flighting/CommonFlight.java # Conflicts: # changelog.txt
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This network check doesn't seem reliable.
(a handful of broker requests failed with this check, but then succeeded with OneAuth.)
This PR will disable the test by default - bringing the behavior in BOTH Broker and Common to match with OneAuth's.
NOTE: Doze mode network check is not in scope of this work.
(that check is set by SDK.