-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use sub claim if oid is missing #4141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Was GetUniqueId() already defined?
Yeah, it's used to compute |
public string GetUniqueId()
{
return ObjectId ?? Subject;
} what does subject return? |
sub claim. I added comments everywhere on this. Seems to be mandatory as per OIDC spec. Should be an ID for app + user, but can theoretically be different for app2 + user. Stable enough for token caching for sure. |
Fixes #4140