[Suggestion] Fix two issues with dSTS authority, one when using WithTenantId, and … #4146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adding dSTS as a supported tenant override. Add a test
bgavrilMS
approved these changes
May 22, 2023
|
PR status seems ok, some CIAM tests are failing due to invalid secret. @gladjohn - should we disable these tests as well? |
|
I will let you merge the PR when the other tests are fixed. Thanks. |
gladjohn
approved these changes
May 22, 2023
pmaytak
approved these changes
May 22, 2023
tests are passing now. Once @neha-bhargava approves we will merge this |
neha-bhargava
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…adding dSTS as a supported tenant override. Add a test
Fixes #4144, fixes #4145
Just a suggestion. I'm having issues running the MSAL tests, so assuming this would work. have tested E2E with Id Web and seems to be working.