Added fix for selenium tests #4650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bgavrilMS,
gladjohn,
pmaytak and
trwalke
pmaytak
approved these changes
Feb 29, 2024
gladjohn
approved these changes
Feb 29, 2024
bgavrilMS
reviewed
Feb 29, 2024
tests/Microsoft.Identity.Test.Integration.netfx/Infrastructure/SeleniumExtensions.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Feb 29, 2024
tests/Microsoft.Identity.Test.Integration.netfx/Infrastructure/SeleniumExtensions.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
approved these changes
Feb 29, 2024
…/SeleniumExtensions.cs Co-authored-by: Bogdan Gavril <bogavril@microsoft.com>
pmaytak
pushed a commit
that referenced
this pull request
Apr 9, 2024
* Added fix for selenium tests * Update tests/Microsoft.Identity.Test.Integration.netfx/Infrastructure/SeleniumExtensions.cs Co-authored-by: Bogdan Gavril <bogavril@microsoft.com> * Address comments --------- Co-authored-by: Bogdan Gavril <bogavril@microsoft.com>
pmaytak
added a commit
that referenced
this pull request
Apr 13, 2024
* Resolving missing test issue in classic pipeline (#4526) Updating value for classic test run * Remove unusused int tests (#4568) * Remove Intune Xamarin dev apps (#4559) * Update installEdgeDriver.ps1 to fetch Edge version dynamically (#4614) * Update installEdgeDriver.ps1 to fetch Edge version dynamically Update installEdgeDriver.ps1 to fetch Edge version dynamically * Update installEdgeDriver.ps1 * Update installEdgeDriver.ps1 * Update test to use lab ppe tenant (#4620) * Update test to use lab ppe tenant * Update ConfidentialAppSettings.cs * Add harden runner on benchmark-action.yml (#4640) Update benchmark-action.yml * Add harden runner on trigger_onebranch_ci.yml (#4641) Update trigger_onebranch_ci.yml * [Code Scan] Refine GitHub Actions Workflow Permissions for Enhanced Security (#4647) * Update trigger_onebranch_ci.yml * Update benchmark-action.yml * Added fix for selenium tests (#4650) * Added fix for selenium tests * Update tests/Microsoft.Identity.Test.Integration.netfx/Infrastructure/SeleniumExtensions.cs Co-authored-by: Bogdan Gavril <bogavril@microsoft.com> * Address comments --------- Co-authored-by: Bogdan Gavril <bogavril@microsoft.com> * Removing ADAL cache compat tests (#4663) * Removing ADAL cache compat tests * clean up * Disabling faulty tests --------- Co-authored-by: trwalke <trwalke@microsoft.com> * Use MSI based Resource Manager for Builds / Tests (#4674) * Update template-install-keyvault-secrets.yaml * Update template-install-keyvault-secrets.yaml * Update template-install-keyvault-secrets.yaml * Update template-install-keyvault-secrets.yaml * Update template-install-keyvault-secrets.yaml * [OneBranch] Update InstallAndroid.ps1 and install android 31 (#4675) Update InstallAndroid.ps1 * Try to fix the tests failing on one branch (#4680) * Delete .github/workflows/scorecard.yml * Update to use lab app for automation (#4700) * initial * UseAppIdUri * use lab vault * LabVaultAccessCert --------- Co-authored-by: Gladwin Johnson <gljohns@microsoft.com> * Tests should run in headless mode * Update Selenium dependencies (#4709) * Update test dependency versions. * Add no-sandbox Edge argument. * Fix perf project. * Fix. * Remove no-sandbox flag. --------- Co-authored-by: Travis Walker <travis.walker@microsoft.com> Co-authored-by: Bogdan Gavril <bogavril@microsoft.com> Co-authored-by: Gladwin Johnson <90415114+gladjohn@users.noreply.github.com> Co-authored-by: Neha Bhargava <61847233+neha-bhargava@users.noreply.github.com> Co-authored-by: trwalke <trwalke@microsoft.com> Co-authored-by: Gladwin Johnson <gljohns@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Fix for selenium tests in build
Changes proposed in this request
Add a step to click next button if the confirmation page comes
Testing
Performance impact
Documentation