Update the SF flow to get a http client from the factory

[neha-bhargava]

This pull request introduces a new interface IMsalSFHttpClientFactory to handle custom server certificate validation for Service Fabric scenarios and refactors the existing HTTP manager code to support this new interface. The most important changes include the addition of the new interface, modification of existing methods to use the new validation callback, and updates to various classes to ensure compatibility.

New Interface for Custom Certificate Validation:

• src/client/Microsoft.Identity.Client/AppConfig/IMsalSFHttpClientFactory.cs: Introduced the IMsalSFHttpClientFactory interface to create HttpClient instances with custom server certificate validation callbacks.

Refactoring HTTP Manager:

• src/client/Microsoft.Identity.Client/Http/HttpManager.cs: Refactored SendRequestAsync and ExecuteAsync methods to use the new validateServerCert callback instead of customHttpClient. Updated GetHttpClient method to handle the new interface and create HttpClient instances appropriately. [1] [2] [3] [4] [5] [6] [7]

Interface Updates:

• src/client/Microsoft.Identity.Client/Http/IHttpManager.cs: Updated the IHttpManager interface to replace the customHttpClient parameter with the validateServerCertificate callback in the SendRequestAsync method. [1] [2] [3]

Class Method Updates:

• src/client/Microsoft.Identity.Client/Instance/Region/RegionManager.cs: Modified methods to use the validateServerCertificate callback instead of customHttpClient. [1] [2] [3]
• src/client/Microsoft.Identity.Client/Instance/Validation/AdfsAuthorityValidator.cs: Updated the ValidateAuthorityAsync method to use the validateServerCertificate callback. [1] [2]
• src/client/Microsoft.Identity.Client/ManagedIdentity/AbstractManagedIdentity.cs: Adjusted the AuthenticateAsync method to use the validateServerCertificate callback and added a new ValidateServerCertificate method for custom validation logic. [1] [2] [3]

Additional Cleanups:

• Removed unused imports and cleaned up code in various files to improve readability and maintainability. [1] [2] [3]Fixes [Bug] Enable SF flow to get a HttpClient from the factory #5220

Changes proposed in this request

• Update the SF flow to get a http client from the factory
• Update the SimpleHttpClientFactory to implement the method to get client with handler
• Update the HttpManager with the changes
• Add tests
• Update the tests

Testing

Performance impact

Documentation

• All relevant documentation is updated.

[Copilot]

Copilot reviewed 18 out of 24 changed files in this pull request and generated 1 comment.

Files not reviewed (6)

• src/client/Microsoft.Identity.Client/PublicApi/net462/PublicAPI.Unshipped.txt: Language not supported
• src/client/Microsoft.Identity.Client/PublicApi/net472/PublicAPI.Unshipped.txt: Language not supported
• src/client/Microsoft.Identity.Client/PublicApi/net8.0-android/PublicAPI.Unshipped.txt: Language not supported
• src/client/Microsoft.Identity.Client/PublicApi/net8.0-ios/PublicAPI.Unshipped.txt: Language not supported
• src/client/Microsoft.Identity.Client/PublicApi/net8.0/PublicAPI.Unshipped.txt: Language not supported
• src/client/Microsoft.Identity.Client/PublicApi/netstandard2.0/PublicAPI.Unshipped.txt: Language not supported

Comments suppressed due to low confidence (1)

src/client/Microsoft.Identity.Client/Http/HttpManager.cs:155

• [nitpick] There is an inconsistency in naming the certificate validation callback parameter ('validateServerCert' versus 'validateServerCertificate' in other parts of the code). Standardizing this naming across the codebase would improve clarity.

if (validateServerCert != null)

[gladjohn]

the PR looks good. well-commented, logically consistent, and with good test coverage. just some minor comments.

[christothes]

LGTM

[bgavrilMS]

I don't think there's any benefit from caching HttpClient. HttpClient is just a holder of handlers. It's the handlers that need to be cached.