Skip to content

update the deprecated openURL(:) api to openURL(:options:completionHandler) #5354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 25, 2025
+2 −2
Merged

update the deprecated openURL(:) api to openURL(:options:completionHandler) #5354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a75863f
update deprecated url apis
DharshanBJ Jun 18, 2025
2c691f1
update
DharshanBJ Jun 18, 2025
dacdb16
Merge branch 'main' into dharshanb/updateDeprecatedUrl
DharshanBJ Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/client/Microsoft.Identity.Client/Platforms/iOS/Broker/iOSBroker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ private Dictionary<string, string> CreateBrokerRequestDictionary(
[System.Diagnostics.CodeAnalysis.SuppressMessage("Interoperability", "CA1422:Validate platform compatibility", Justification = "<Pending>")]
public void HandleInstallUrl(string appLink)
{
DispatchQueue.MainQueue.DispatchAsync(() => UIApplication.SharedApplication.OpenUrl(new NSUrl(appLink)));
DispatchQueue.MainQueue.DispatchAsync(() => UIApplication.SharedApplication.OpenUrl(new NSUrl(appLink), new UIApplicationOpenUrlOptions(), null));

throw new MsalClientException(
MsalError.BrokerApplicationRequired,
Expand Down
2 changes: 1 addition & 1 deletion ...client/Microsoft.Identity.Client/Platforms/iOS/EmbeddedWebview/WKWebNavigationDelegate.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public override void DecidePolicy(WKWebView webView, WKNavigationAction navigati

#pragma warning disable CA1422 // Validate platform compatibility
DispatchQueue.MainQueue.DispatchAsync(
() => UIApplication.SharedApplication.OpenUrl(new NSUrl(requestUrlString)));
() => UIApplication.SharedApplication.OpenUrl(new NSUrl(requestUrlString), new UIApplicationOpenUrlOptions(), null));
#pragma warning restore CA1422 // Validate platform compatibility
_authenticationAgentUIViewController.DismissViewController(true, null);
decisionHandler(WKNavigationActionPolicy.Cancel);
Expand Down