ImdsV2: Additional Acceptance Tests #5465
Merged
+371
−162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robbie-Microsoft
changed the title
bgavrilMS
reviewed
Sep 10, 2025
tests/Microsoft.Identity.Test.Unit/ManagedIdentityTests/ImdsV2Tests.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Sep 10, 2025
tests/Microsoft.Identity.Test.Unit/ManagedIdentityTests/ImdsV2Tests.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Sep 10, 2025
| .WithCsrFactory(_testCsrFactory); | ||
|
|
||
| // Disabling shared cache options to avoid cross test pollution. | ||
| miBuilder.Config.AccessorOptions = null; |
Member
There was a problem hiding this comment.
Don't we have a "ResetCachesForTest" API now? If not, do we have a work item for it ? It's part of the static caching of the MSI source story.
Contributor
Author
There was a problem hiding this comment.
Per offline discussion, will be addressed in a future PR
bgavrilMS
reviewed
Sep 10, 2025
gladjohn
reviewed
Sep 11, 2025
| } | ||
| #endregion | ||
|
|
||
| [TestMethod] |
Contributor
There was a problem hiding this comment.
can we also add negative tests that simulate service failures?
Contributor
Author
There was a problem hiding this comment.
Per offline discussion, will be addressed in a future PR
bgavrilMS
approved these changes
Sep 11, 2025
gladjohn
approved these changes
Sep 11, 2025
Robbie-Microsoft
merged commit 8182762
into
rginsburg/msiv2_entra_token_request_headers
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added additional acceptance tests for bearer and mtls pop tokens, and done a major refactoring of the unit tests.