ESTS-Regional support #306
Conversation
abhidnya13
added
enhancement
abhidnya13
added
enhancement
apps/confidential/confidential.go
Outdated
| @@ -245,6 +253,23 @@ func WithX5C() Option { | |||
| } | |||
| } | |||
|
|
|||
| // WithAzureRegionsets the region(preferred) or Confidential.AutoDetectRegion() for auto detecting region. | |||
There was a problem hiding this comment.
space after "WithAzureRegion"
abhidnya13
added
enhancement
abhidnya13
added
enhancement
abhidnya13
added
enhancement
| err := c.Comm.JSONCall(ctx, endpoint, http.Header{}, qv, nil, &resp) | ||
| return resp, err | ||
| resp := "" | ||
| err := c.Comm.JSONCall(ctx, imdsEndpoint, http.Header{}, nil, nil, &resp) |
There was a problem hiding this comment.
qv isn't being passed in here anymore?
abhidnya13
added
enhancement
| qv.Set("api-version", defaultAPIVersion) | ||
| qv.Set("format", "text") | ||
| resp := "" | ||
| err := c.Comm.JSONCall(ctx, imdsEndpoint, http.Header{}, qv, nil, &resp) |
There was a problem hiding this comment.
design doc indicates that this call should be retried once.
Additionally, do we want to handle discovery here for new versions? Specified as optional in the design doc.
There was a problem hiding this comment.
AzureAD/microsoft-authentication-library-for-python#358 (comment)
I was following this discussion and decided to go with the simpler approach of trying it only once.
I'll update to use the latest API version though as per this doc. https://docs.microsoft.com/en-us/azure/virtual-machines/windows/instance-metadata-service?tabs=linux#supported-api-versions
| } | ||
| resp.Metadata = []InstanceDiscoveryMetadata{metadata} | ||
| } | ||
| if region == "" { |
There was a problem hiding this comment.
am I reading this wrong, or could this just be an else?
abhidnya13
added
enhancement
abhidnya13
added
enhancement
abhidnya13
added
enhancement
|
Kudos, SonarCloud Quality Gate passed!
|
abhidnya13
added
enhancement
This resolves #240
This is the internal design doc: AAD SDK Proposal to Pin Auth to region
I was able to E2E test this by specifying an Azure Region using this sample app.
Also added a wiki page to show usage details.