Improve region support and add region telemetry #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangonzal
reviewed
May 17, 2021
SomkaPe
reviewed
May 27, 2021
src/main/java/com/microsoft/aad/msal4j/AadInstanceDiscoveryProvider.java
Show resolved
Hide resolved
src/main/java/com/microsoft/aad/msal4j/AadInstanceDiscoveryProvider.java
Show resolved
Hide resolved
src/main/java/com/microsoft/aad/msal4j/AadInstanceDiscoveryProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/aad/msal4j/AadInstanceDiscoveryProvider.java
Show resolved
Hide resolved
SomkaPe
reviewed
May 27, 2021
src/main/java/com/microsoft/aad/msal4j/AbstractClientApplicationBase.java
Show resolved
Hide resolved
SomkaPe
reviewed
May 27, 2021
src/main/java/com/microsoft/aad/msal4j/AcquireTokenSilentSupplier.java
Outdated
Show resolved
Hide resolved
…tion-library-for-java into avdunn/improved-region-support � Conflicts: � src/main/java/com/microsoft/aad/msal4j/AadInstanceDiscoveryProvider.java
SomkaPe
approved these changes
Jun 8, 2021
Avery-Dunn
added a commit
that referenced
this pull request
Jun 16, 2021
* Pesomka/b2b stage1 (#356) multi cloud accounts * Pesomka/key store provider (#358) general purpose API should not be tied to specific security provider * Instance aware support (#362) Instance aware support for interactive requests * Update telemetry to reduce size of payload (#361) * Update telemetry implementation * Bump guava from 26.0-jre to 29.0-jre (#366) Bumps [guava](https://github.com/google/guava) from 26.0-jre to 29.0-jre. * Bump guava from 26.0-jre to 29.0-jre in /src/samples/msal-obo-sample (#367) Bumps [guava](https://github.com/google/guava) from 26.0-jre to 29.0-jre. * survey added to README.md Loyalty developer survey added to README.md Link placed in tab and new feedback section. * Update oauth2-oidc-sdk dependency (#373) Upgrade oauth2-oidc-sdk dependency * Add default cache lookup to client credential flow (#368) * Add default cache lookup to client credential flow * Bump commons-io from 2.6 to 2.7 (#376) Bumps commons-io from 2.6 to 2.7. * Sagonzal/update client credentials (#377) * Update obo flow to attempt cache lookup by default * 1.10.0 release * fix for issue with common scopes override (#385) fix for issue with common scopes override * Add ccs routing headers. Add option to pass in header map * Rename IApiParameters to IAcquireTokenParameters * PR Feedback * Add CCS routing information to /authorize query parameters * Update log levels for operations in OBO and ClientCredential supliers * Update how non 200 http response are handled. Update to only throw MsalExceptions * Update unit tests * Retrigger build * Update unit test * Bump httpclient from 4.5.9 to 4.5.13 (#401) Bumps httpclient from 4.5.9 to 4.5.13. --- updated-dependencies: - dependency-name: org.apache.httpcomponents:httpclient dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Improve region support and add region telemetry (#388) * Improve region support and add region telemetry * Finish implementation of most recent telemetry design * Update oauth dependency * Address code review comments * integration test for cross cloud b2b (#396) integration test for cross cloud b2b * Version and changelog updates for release 1.10.1 (#405) * Fix merge conflicts Co-authored-by: SomkaPe <pesomka@microsoft.com> Co-authored-by: Santiago Gonzalez <35743865+sangonzal@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: ShannonCanTech <shfost@microsoft.com> Co-authored-by: Santiago Gonzalez <sagonzal@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves support for Azure regions and updates telemetry to follow the most recent schema, as per this region design doc and this telemetry design doc.
Additionally, updates the oauth2-oidc-sdk dependency to fix an issue with the transitive json-smart dependency mentioned in #394