Fix Www-Authenticate not being read #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blancqua
force-pushed
the
blancqua/www-auth-fix
branch
from
37a3ce5 to
ea1e8dd
Compare
|
@microsoft-github-policy-service agree |
blancqua
force-pushed
the
blancqua/www-auth-fix
branch
from
ea1e8dd to
7ecb1b3
Compare
bgavrilMS
reviewed
Dec 5, 2024
| return response.headers() | ||
| .entrySet() | ||
| .stream() | ||
| .filter(entry -> WWW_AUTHENTICATE_HEADER.equalsIgnoreCase(entry.getKey())) |
There was a problem hiding this comment.
I think this warrants a unit test, just updating the existing one from here 68bba51#diff-c1e78d16db8b6cb86ef4e37c4f14c7950221b0fd619b2ab501499c588b5c0833R620
There was a problem hiding this comment.
Hi @bgavrilMS ! I extended the existing tests to run with both variations of the header key. Slipped in some small refactor as well to avoid duplication, hope you don't mind.
blancqua
force-pushed
the
blancqua/www-auth-fix
branch
from
7ecb1b3 to
85846f8
Compare
|
Hi @bgavrilMS ! I extended the existing tests to run with both variations of the header key. Slipped in some small refactor as well to avoid duplication, hope you don't mind. |
bgavrilMS
approved these changes
Dec 6, 2024
Avery-Dunn
approved these changes
Dec 6, 2024
|
Thanks, any clue when there might be a release including this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #884