Allow pop params for brokered flows (#7335)

Adds POP params in request types to allow acquisition of POP tokens from MSAL Runtime brokered flows
AzureAD · Oct 1, 2024 · 704a8de · 704a8de
1 parent 68d29bb
commit 704a8de
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 21 deletions.
diff --git a/change/@azure-msal-node-b12e3eee-b810-4217-8578-e4d655383620.json b/change/@azure-msal-node-b12e3eee-b810-4217-8578-e4d655383620.json
@@ -0,0 +1,7 @@
+{
+ "type": "patch",
+ "comment": "Allow POP Params for brokered requests",
+ "packageName": "@azure/msal-node",
+ "email": "thomas.norling@microsoft.com",
+ "dependentChangeType": "patch"
+}
diff --git a/lib/msal-node/apiReview/msal-node.api.md b/lib/msal-node/apiReview/msal-node.api.md
@@ -351,7 +351,7 @@ export { InteractionRequiredAuthErrorCodes }
 export { InteractionRequiredAuthErrorMessage }
 
 // @public
-export type InteractiveRequest = Pick<AuthorizationUrlRequest, "authority" | "correlationId" | "claims" | "azureCloudOptions" | "account" | "extraQueryParameters" | "tokenQueryParameters" | "extraScopesToConsent" | "loginHint" | "prompt"> & {
+export type InteractiveRequest = Partial<Omit<CommonAuthorizationUrlRequest, "scopes" | "redirectUri" | "requestedClaimsHash" | "storeInCache">> & {
  openBrowser: (url: string) => Promise<void>;
  scopes?: Array<string>;
  successTemplate?: string;
@@ -692,7 +692,7 @@ export type SignOutRequest = {
 };
 
 // @public
-export type SilentFlowRequest = Partial<Omit<CommonSilentFlowRequest, "account" | "scopes" | "resourceRequestMethod" | "resourceRequestUri" | "requestedClaimsHash" | "storeInCache">> & {
+export type SilentFlowRequest = Partial<Omit<CommonSilentFlowRequest, "account" | "scopes" | "requestedClaimsHash" | "storeInCache">> & {
  account: AccountInfo;
  scopes: Array<string>;
 };

diff --git a/lib/msal-node/src/request/InteractiveRequest.ts b/lib/msal-node/src/request/InteractiveRequest.ts
@@ -3,8 +3,8 @@
  * Licensed under the MIT License.
  */
 
+import { CommonAuthorizationUrlRequest } from "@azure/msal-common/node";
 import { ILoopbackClient } from "../network/ILoopbackClient.js";
-import { AuthorizationUrlRequest } from "./AuthorizationUrlRequest.js";
 
 /**
  * Request object passed by user to configure acquireTokenInteractive API
@@ -17,18 +17,11 @@ import { AuthorizationUrlRequest } from "./AuthorizationUrlRequest.js";
  * - loopbackClient - Custom implementation for a loopback server to listen for authorization code response.
  * @public
  */
-export type InteractiveRequest = Pick<
- AuthorizationUrlRequest,
- | "authority"
- | "correlationId"
- | "claims"
- | "azureCloudOptions"
- | "account"
- | "extraQueryParameters"
- | "tokenQueryParameters"
- | "extraScopesToConsent"
- | "loginHint"
- | "prompt"
+export type InteractiveRequest = Partial<
+ Omit<
+ CommonAuthorizationUrlRequest,
+ "scopes" | "redirectUri" | "requestedClaimsHash" | "storeInCache"
+ >
 > & {
  openBrowser: (url: string) => Promise<void>;
  scopes?: Array<string>;

diff --git a/lib/msal-node/src/request/SilentFlowRequest.ts b/lib/msal-node/src/request/SilentFlowRequest.ts
@@ -19,12 +19,7 @@ import { AccountInfo, CommonSilentFlowRequest } from "@azure/msal-common/node";
 export type SilentFlowRequest = Partial<
  Omit<
  CommonSilentFlowRequest,
- | "account"
- | "scopes"
- | "resourceRequestMethod"
- | "resourceRequestUri"
- | "requestedClaimsHash"
- | "storeInCache"
+ "account" | "scopes" | "requestedClaimsHash" | "storeInCache"
  >
 > & {
  account: AccountInfo;