Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update browserslist and docs around browser support #3422

Closed
wants to merge 7 commits into from

Conversation

tnorling
Copy link
Collaborator

@tnorling tnorling commented Apr 8, 2021

  • Updates docs to explicitly define what browsers we support
  • Moves IE 11 caveats/known-issues from wiki to new markdown doc
  • Adds .browserslistrc defining which browsers we support (this helps prevent certain polyfills for older browsers from being included)
  • Adds postinstall step to update the browser list db with the most up to date information (open to feedback around where this should go, it should happen at minimum before releasing)

Closes #3396 by removing polyfill that was causing a conflict with script-src CSP.

This was tested and does not break ie11 compatibility as long as the ie11 polyfills are still included in any apps that need to support ie11 (demonstrated in the react-router sample and ie 11 sample).

@github-actions github-actions bot added msal-react Related to @azure/msal-react samples Related to the samples apps for the library. labels Apr 8, 2021
@coveralls
Copy link

coveralls commented Apr 8, 2021

Coverage Status

Coverage decreased (-83.7%) to 0.0% when pulling fa0e8bf8b32c0c305b6ec98cefdea29c50997e70 on msal-react-browserslist into ee64805 on dev.

@tnorling tnorling requested a review from pkanher617 as a code owner April 14, 2021 20:43
@github-actions github-actions bot added documentation Related to documentation. msal-browser Related to msal-browser package labels Apr 14, 2021
@github-actions github-actions bot added msal-angular Related to @azure/msal-angular package msal-common Related to msal-common package msal-node Related to msal-node package msal@1.x Related to msal@1.x (implicit flow) labels Apr 15, 2021
@tnorling tnorling changed the title Update msal-react browserslist to prevent bundling unnecessary polyfills Update browserslist and docs around browser support Apr 15, 2021
@tnorling tnorling force-pushed the msal-react-browserslist branch from 807f01f to cbec0d1 Compare April 15, 2021 00:46
@tnorling tnorling closed this Apr 15, 2021
@tnorling tnorling deleted the msal-react-browserslist branch May 17, 2021 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation. msal@1.x Related to msal@1.x (implicit flow) msal-angular Related to @azure/msal-angular package msal-browser Related to msal-browser package msal-common Related to msal-common package msal-node Related to msal-node package msal-react Related to @azure/msal-react samples Related to the samples apps for the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MsalProvider gives Content Security Policy directive: "script-src 'self'" error
3 participants