Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump Playwright to 1.28 #5450

Closed
wants to merge 3 commits into from
Closed

chore: bump Playwright to 1.28 #5450

wants to merge 3 commits into from

Conversation

mxschmitt
Copy link
Contributor

@mxschmitt mxschmitt commented Dec 5, 2022 •
edited
Loading

Context: microsoft/playwright#19246

drive-by: remove playwright dependency, since this installs all the 3 Playwright browsers as well which you don't need.

It was locally for me working on the microsoft/playwright#18928 (comment) branch.

@ghost ghost assigned hectormmg and jo-arroyo Dec 5, 2022
@github-actions github-actions bot added the samples Related to the samples apps for the library. label Dec 5, 2022
@mxschmitt mxschmitt mentioned this pull request Dec 5, 2022
Closed
@hectormmg
Copy link
Member

@mxschmitt thanks for the PR, we'll take a look and get try to get it merged!

@mxschmitt
Copy link
Contributor Author

Would be helpful if we could run the e2e tests on this PR to verify nothing regressed.

Thanks!

derisen
derisen approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@derisen derisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thansk @mxschmitt -not sure why CI is skipping E2E tests, but they ran fine locally cc @hectormmg

@hectormmg
Copy link
Member

thansk @mxschmitt Max Schmitt FTE -not sure why CI is skipping E2E tests, but they ran fine locally cc @hectormmg Hector Morales FTE

CI checks are blocked on external PRs for security reasons, we have to manually authorize them

@tnorling
Copy link
Collaborator

tnorling commented Dec 7, 2022

thansk @mxschmitt Max Schmitt FTE -not sure why CI is skipping E2E tests, but they ran fine locally cc @hectormmg Hector Morales FTE

CI checks are blocked on external PRs for security reasons, we have to manually authorize them

You can pull this into a "staging" branch and open a new PR to dev to allow the E2E tests to run

@derisen derisen mentioned this pull request Dec 8, 2022
Merged
@tnorling
Copy link
Collaborator

tnorling commented Dec 9, 2022

Closing in favor of #5470 which includes these changes

@tnorling tnorling closed this Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derisen derisen derisen approved these changes

@hectormmg hectormmg hectormmg approved these changes

@sameerag sameerag Awaiting requested review from sameerag sameerag is a code owner

@tnorling tnorling Awaiting requested review from tnorling tnorling is a code owner

@bmahall bmahall Awaiting requested review from bmahall

@peterzenz peterzenz Awaiting requested review from peterzenz peterzenz is a code owner

@jennyf19 jennyf19 Awaiting requested review from jennyf19

@jmprieur jmprieur Awaiting requested review from jmprieur

@bgavrilMS bgavrilMS Awaiting requested review from bgavrilMS bgavrilMS is a code owner

@Robbie-Microsoft Robbie-Microsoft Awaiting requested review from Robbie-Microsoft Robbie-Microsoft is a code owner

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@lalimasharda lalimasharda Awaiting requested review from lalimasharda lalimasharda is a code owner

Assignees

@hectormmg hectormmg

@jo-arroyo jo-arroyo

Labels
samples Related to the samples apps for the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mxschmitt @hectormmg @tnorling @derisen @jo-arroyo