Converted Certificate Sample to TypeScript #7368
Conversation
samples/msal-node-samples/client-credentials-with-cert-from-key-vault/tsconfig.json
Show resolved
Hide resolved
| @@ -6,4 +6,5 @@ | |||
| module.exports = { | |||
| displayName: "Client Credentials with Certificate from Key Vault", | |||
| preset: "../../e2eTestUtils/jest-puppeteer-utils/jest-preset-no-setup.js", | |||
| extensionsToTreatAsEsm: [".ts", ".tsx"], | |||
There was a problem hiding this comment.
I was getting some build errors without this
There was a problem hiding this comment.
Is this an old run? It's referencing jest.config.js being treated as ESM but the file is, correctly, named jest.config.cjs now
There was a problem hiding this comment.
It is an old run. I receive that error when the file ends with ".js" instead of ".cjs". I can Google the difference I suppose, but for the purpose of discussion here, what is the ;TLDR difference between the two?
I can try keeping the file as ".cjs" and removing that line you asked the question about, and see if I still receive the build error.
There was a problem hiding this comment.
Different module formats. If you've specified type: "module" in the package.json, .js file extensions are treated as ESM. Without the type specified .js extensions are treated as CJS. To explicitly use CJS or ESM use .cjs or .mjs respectively. In this case the config is written using CJS syntax so it either needs to use .cjs or remove type: "module" from the package.json
This is the first time we'll have an E2E test running on a TypeScript sample. They all currently run on JS samples.