-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[Native Auth] Remove preview warning and typo fix #8147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes experimental/preview warnings from Native Authentication MFA and authentication method registration APIs, indicating these features are ready for production use. It also fixes a typo in test constants and improves error logging messages.
Key Changes:
- Removed
@warningJSDoc tags from 13 public API methods across MFA and JIT authentication flows - Fixed typo:
TestAccounDetails→TestAccountDetailsin test files - Enhanced error logging to include error details for better debugging
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/msal-browser/test/custom_auth/test_resources/TestModules.ts | Updated import formatting from single line to multi-line for better readability |
| lib/msal-browser/test/custom_auth/test_resources/TestConstants.ts | Fixed typo in constant name: TestAccounDetails → TestAccountDetails |
| lib/msal-browser/test/custom_auth/get_account/interaction_client/CustomAuthSilentCacheClient.spec.ts | Updated test references to use corrected TestAccountDetails constant |
| lib/msal-browser/test/custom_auth/core/auth_flow/mfa/state/MfaState.spec.ts | Updated test references to use corrected TestAccountDetails constant |
| lib/msal-browser/src/custom_auth/sign_in/auth_flow/result/SignInSubmitPasswordResult.ts | Removed experimental warnings from isAuthMethodRegistrationRequired() and isMfaRequired() methods |
| lib/msal-browser/src/custom_auth/sign_in/auth_flow/result/SignInSubmitCodeResult.ts | Removed experimental warnings from isAuthMethodRegistrationRequired() and isMfaRequired() methods |
| lib/msal-browser/src/custom_auth/sign_in/auth_flow/result/SignInResult.ts | Removed experimental warnings from isAuthMethodRegistrationRequired() and isMfaRequired() methods |
| lib/msal-browser/src/custom_auth/core/auth_flow/mfa/state/MfaState.ts | Removed experimental warnings from 4 MFA state methods |
| lib/msal-browser/src/custom_auth/core/auth_flow/mfa/result/MfaSubmitChallengeResult.ts | Removed experimental warnings from isCompleted() and isFailed() methods |
| lib/msal-browser/src/custom_auth/core/auth_flow/mfa/result/MfaRequestChallengeResult.ts | Removed experimental warnings from isVerificationRequired() and isFailed() methods |
| lib/msal-browser/src/custom_auth/core/auth_flow/jit/state/AuthMethodRegistrationState.ts | Removed experimental warnings from 7 auth method registration methods and improved error logging with error details |
| lib/msal-browser/src/custom_auth/core/auth_flow/jit/result/AuthMethodRegistrationSubmitChallengeResult.ts | Removed experimental warnings from isCompleted() and isFailed() methods |
| lib/msal-browser/src/custom_auth/core/auth_flow/jit/result/AuthMethodRegistrationChallengeMethodResult.ts | Removed experimental warnings from 3 result checking methods |
No description provided.