Skip to content

Conversation

@shenj
Copy link
Contributor

@shenj shenj commented Nov 18, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 18, 2025 10:03
Copilot finished reviewing on behalf of shenj November 18, 2025 10:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes experimental/preview warnings from Native Authentication MFA and authentication method registration APIs, indicating these features are ready for production use. It also fixes a typo in test constants and improves error logging messages.

Key Changes:

  • Removed @warning JSDoc tags from 13 public API methods across MFA and JIT authentication flows
  • Fixed typo: TestAccounDetailsTestAccountDetails in test files
  • Enhanced error logging to include error details for better debugging

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
lib/msal-browser/test/custom_auth/test_resources/TestModules.ts Updated import formatting from single line to multi-line for better readability
lib/msal-browser/test/custom_auth/test_resources/TestConstants.ts Fixed typo in constant name: TestAccounDetailsTestAccountDetails
lib/msal-browser/test/custom_auth/get_account/interaction_client/CustomAuthSilentCacheClient.spec.ts Updated test references to use corrected TestAccountDetails constant
lib/msal-browser/test/custom_auth/core/auth_flow/mfa/state/MfaState.spec.ts Updated test references to use corrected TestAccountDetails constant
lib/msal-browser/src/custom_auth/sign_in/auth_flow/result/SignInSubmitPasswordResult.ts Removed experimental warnings from isAuthMethodRegistrationRequired() and isMfaRequired() methods
lib/msal-browser/src/custom_auth/sign_in/auth_flow/result/SignInSubmitCodeResult.ts Removed experimental warnings from isAuthMethodRegistrationRequired() and isMfaRequired() methods
lib/msal-browser/src/custom_auth/sign_in/auth_flow/result/SignInResult.ts Removed experimental warnings from isAuthMethodRegistrationRequired() and isMfaRequired() methods
lib/msal-browser/src/custom_auth/core/auth_flow/mfa/state/MfaState.ts Removed experimental warnings from 4 MFA state methods
lib/msal-browser/src/custom_auth/core/auth_flow/mfa/result/MfaSubmitChallengeResult.ts Removed experimental warnings from isCompleted() and isFailed() methods
lib/msal-browser/src/custom_auth/core/auth_flow/mfa/result/MfaRequestChallengeResult.ts Removed experimental warnings from isVerificationRequired() and isFailed() methods
lib/msal-browser/src/custom_auth/core/auth_flow/jit/state/AuthMethodRegistrationState.ts Removed experimental warnings from 7 auth method registration methods and improved error logging with error details
lib/msal-browser/src/custom_auth/core/auth_flow/jit/result/AuthMethodRegistrationSubmitChallengeResult.ts Removed experimental warnings from isCompleted() and isFailed() methods
lib/msal-browser/src/custom_auth/core/auth_flow/jit/result/AuthMethodRegistrationChallengeMethodResult.ts Removed experimental warnings from 3 result checking methods

yongdiw
yongdiw previously approved these changes Nov 18, 2025
@shenj shenj enabled auto-merge (squash) November 18, 2025 12:14
@shenj shenj merged commit 1691947 into dev Nov 18, 2025
7 checks passed
@shenj shenj deleted the native-auth/jiashen/remove-preview-flag branch November 18, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants