client assertion: fix type error #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayluo
reviewed
Jan 17, 2019
| TYPE_JWT = "urn:ietf:params:oauth:client-assertion-type:jwt-bearer" | ||
| TYPE_SAML2 = "urn:ietf:params:oauth:client-assertion-type:saml2-bearer" | ||
| client_assertion_type = TYPE_JWT if "." in client_assertion else TYPE_SAML2 | ||
| client_assertion_type = TYPE_JWT if "." in client_assertion.decode() else TYPE_SAML2 |
Contributor
There was a problem hiding this comment.
@yugangw-msft Thanks for pointing this out! Now I'm actually thinking of do it in the other way around: ... if b"." in client_assertion else ..., due to some other reasons. If you don't mind, you also change it this way and give it a quick run in your local environment, and tell me the result.
Meanwhile I will probably organize such fix in a separate PR, because I'll have other places need same fix, as well as relevant docstrings etc.. And it is not fair to ask you to do all that in YOUR pr. :-) You already help us a lot by spotting this issue first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Python 3.6, the jwt encode would return a byte array