Full support for verify and proxies #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayluo
force-pushed
the
full-support-for-verify-and-proxies
branch
from
73dcdc4 to
583adeb
Compare
rayluo
force-pushed
the
full-support-for-verify-and-proxies
branch
2 times, most recently
from
460fb82 to
ec1e2a7
Compare
rayluo
force-pushed
the
full-support-for-verify-and-proxies
branch
from
ec1e2a7 to
b4e482b
Compare
yugangw-msft
approved these changes
Feb 14, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #15.
How to test?
Use MSAL Python 0.1.0. Start fiddler. Add a
verify=Falseflag in any of the samples. Run it. You won't be able to complete a sample run due to the library complaining (this is essentially a Man-in-the-middle attack).You can test this PR by:
Rerun the previous test. This time you will successfully obtain a token (despite some warning message emitted from underlying library).