Implementing Telemetry V4 #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement Telemetry's app-wide state Test cases for telemetry id on most public methods Test telemetry buffer for offline states
|
@sangonzal FYI, this PR contains some test cases that demonstrate the actual outcome on the wire, such as By the way, have you seen any MSAL utilize that "platform-specific telemetry", i.e. appending more info at the end of the strings above? Pondering to add some platform-specific content here, wondering whether some telemetry consuming scripts would break because of that... UPDATE: Talked with Santiago during e-standup. Platform-specific values are indeed used by some other MSALs too. |
rayluo
commented
Apr 8, 2021
| data=dict( | ||
| kwargs.pop("data", {}), | ||
| claims=_merge_claims_challenge_and_capabilities( | ||
| self._client_capabilities, claims_challenge)), | ||
| nonce=nonce, | ||
| **kwargs)) | ||
| telemetry_context.update_telemetry(resposne) |
There was a problem hiding this comment.
A typo sneaked in. It will be fixed in PR #345
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will close #137 and also close #175