implement response_mode #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oidc supports passing the response_mode to allow redirects to send callback parameters as POST for increased security.
|
|
eopeter
force-pushed
the
eopeter/responseMode
branch
from
13bf239 to
13dd4a7
Compare
rayluo
requested changes
May 12, 2022
There was a problem hiding this comment.
Thank you, @eopeter, for working out this PR, and even proactively refining it for editorial changes.
I leave some comments below.
Co-authored-by: Ray Luo <rayluo.mba@gmail.com>
rayluo
reviewed
May 12, 2022
rayluo
approved these changes
May 12, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #396 and allows specifying response_mode when using authorization code flow. It checks valid values for response_mode