Skip to content

Avoid hardcoding secret #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2019
Merged

Avoid hardcoding secret #49

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
320d143
Avoid hardcoding secret, not even a placeholder
rayluo May 24, 2019
b56a384
Also updating inline comments for the secret param
rayluo Jun 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions sample/authorization-code-flow-sample/authorization_code_flow_sample.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,10 @@
}

You can then run this sample with a JSON configuration file:
python sample.py parameters.json
On the browser open http://localhost:5000/

python sample.py parameters.json your_flask_session_secret_here

And the on the browser open http://localhost:5000/

"""

Expand All @@ -29,7 +31,7 @@

app = flask.Flask(__name__)
app.debug = True
app.secret_key = 'development'
app.secret_key = sys.argv[2] # In this demo, we expect a secret from 2nd CLI param


# Optional logging
Expand Down