Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing the Container and ValueOrReference from the public API of CredentialDescription #151

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Removing the Container and ValueOrReference from the public API of CredentialDescription #151

merged 2 commits into from
Jan 23, 2025

Conversation

jmprieur
Copy link
Contributor

@jmprieur jmprieur commented Jan 23, 2025 •
edited
Loading

Removing the Container and ValueOrReference from the public API of CredentialDescription. They were there for compat with IdWeb 1.x and part of the technical debt

Removing the Container and ValueOrReference from the public API of CredentialDescription

  • Removing technical debt. These properties are now internal, which avoids them to be serialized or bound, which is no longer desirable since Id.Web 2.x
  • This is a breaking change (these properties become internal) so bumping the library to 8.0.0.

@jmprieur
Removing the Container and ValueOrReference from the public API of Cr…
a20447b 
…edentialDescription. They were there for compat with IdWeb 1.x and part of the technical debt
@jmprieur jmprieur requested a review from a team as a code owner January 23, 2025 00:43
kllysng
kllysng approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@kllysng kllysng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmprieur jmprieur merged commit 735aaad into main Jan 23, 2025
4 checks passed
@jmprieur jmprieur deleted the jmprieur/cleanupCompatProperties branch January 23, 2025 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshLozensky JoshLozensky JoshLozensky approved these changes

@kllysng kllysng kllysng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmprieur @kllysng @JoshLozensky