Skip to content

Commit

Permalink
Removing reference to Iddp Code Signing (#2941)
Browse files Browse the repository at this point in the history
  • Loading branch information
trwalke authored Jul 18, 2024
1 parent 1e6f70f commit 78e87da
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 118 deletions.
29 changes: 0 additions & 29 deletions build/release-provisioning-tool.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,35 +68,6 @@ steps:
Contents: '**\*nupkg'
TargetFolder: '$(Build.ArtifactStagingDirectory)\packages'
flattenFolders: true

# Sign all final nuget packages in the staging directory
- task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@1
displayName: 'Sign Packages'
inputs:
ConnectedServiceName: 'IDDP Code Signing'
FolderPath: '$(Build.ArtifactStagingDirectory)\packages'
Pattern: '*nupkg'
signConfigType: inlineSignParams
inlineOperation: |
[
{
"keyCode": "CP-401405",
"operationSetCode": "NuGetSign",
"parameters": [ ],
"toolName": "sign",
"toolVersion": "1.0"
},
{
"keyCode": "CP-401405",
"operationSetCode": "NuGetVerify",
"parameters": [ ],
"toolName": "sign",
"toolVersion": "1.0"
}
]
SessionTimeout: 20
VerboseLogin: true
timeoutInMinutes: 5

# Publish nuget packages and symbols to VSTS package manager.
- template: template-publish-packages-and-symbols.yaml
Expand Down
89 changes: 0 additions & 89 deletions build/template-pack-and-sign-all-nugets.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,56 +13,6 @@ steps:
inputs:
version: 2.x

- task: EsrpCodeSigning@4
inputs:
ConnectedServiceName: 'IDDP Code Signing'
FolderPath: '$(Build.SourcesDirectory)\$(IdWebSourceDir)src'
Pattern: 'Microsoft.Identity.Web*.dll'
signConfigType: 'inlineSignParams'
inlineOperation: |
[
{
"keyCode": "CP-230012",
"operationSetCode": "SigntoolSign",
"parameters": [
{
"parameterName": "OpusName",
"parameterValue": "Microsoft.Identity.Web"
},
{
"parameterName": "OpusInfo",
"parameterValue": "http://www.microsoft.com"
},
{
"parameterName": "PageHash",
"parameterValue": "/NPH"
},
{
"parameterName": "FileDigest",
"parameterValue": "/fd sha256"
},
{
"parameterName": "TimeStamp",
"parameterValue": "/tr \"http://rfc3161.gtm.corp.microsoft.com/TSS/HttpTspServer\" /td sha256"
}
],
"toolName": "signtool.exe",
"toolVersion": "6.2.9304.0"
},
{
"keyCode": "CP-230012",
"operationSetCode": "SigntoolVerify",
"parameters": [ ],
"toolName": "signtool.exe",
"toolVersion": "6.2.9304.0"
}
]
SessionTimeout: '60'
MaxConcurrency: '50'
MaxRetryAttempts: '5'
PendingAnalysisWaitTimeoutMinutes: '5'
condition: and(succeeded(), eq(variables['PipelineType'], 'Legacy'))

- task: onebranch.pipeline.signing@1
displayName: 'Sign ${{ parameters.LibraryName }} with OneBranch'
inputs:
Expand Down Expand Up @@ -192,37 +142,6 @@ steps:
TargetFolder: '$(Build.ArtifactStagingDirectory)\packages'
flattenFolders: true

# Sign all final nuget packages in the staging directory
- task: EsrpCodeSigning@4
displayName: 'Sign Packages'
inputs:
ConnectedServiceName: 'IDDP Code Signing'
FolderPath: '$(Build.ArtifactStagingDirectory)\packages'
Pattern: '*nupkg'
signConfigType: inlineSignParams
inlineOperation: |
[
{
"keyCode": "CP-401405",
"operationSetCode": "NuGetSign",
"parameters": [ ],
"toolName": "sign",
"toolVersion": "1.0"
},
{
"keyCode": "CP-401405",
"operationSetCode": "NuGetVerify",
"parameters": [ ],
"toolName": "sign",
"toolVersion": "1.0"
}
]
SessionTimeout: '60'
MaxConcurrency: '50'
MaxRetryAttempts: '5'
PendingAnalysisWaitTimeoutMinutes: '5'
condition: and(succeeded(), eq(variables['PipelineType'], 'Legacy'))

- task: onebranch.pipeline.signing@1
displayName: 'Sign Packages with OneBranch'
inputs:
Expand All @@ -231,11 +150,3 @@ steps:
files_to_sign: '*nupkg'
search_root: '$(Build.ArtifactStagingDirectory)\packages'
condition: and(succeeded(), eq(variables['PipelineType'], 'OneBranch'))

- task: NuGetCommand@2
displayName: 'Verify packages are signed'
inputs:
command: custom
arguments: 'verify -Signature ${{ parameters.NugetPackagesWildcard }}'
continueOnError: true
condition: and(succeeded(), eq(variables['PipelineType'], 'Legacy'))

0 comments on commit 78e87da

Please sign in to comment.