Skip to content

Commit

Permalink
Update rel/v2 with lab api/lab app changes (#2746)
Browse files Browse the repository at this point in the history
* Updating lab api to 0.12.2 (#2744)

* Updating to Lab.Api 0.12.2

* Updating keyvault target

* Updating lab service connection

* Fixing typo

* Update

---------

Co-authored-by: trwalke <trwalke@microsoft.com>

* Updating constants for lab apps (#2745)

* Updating constants

* revert

---------

Co-authored-by: trwalke <trwalke@microsoft.com>

---------

Co-authored-by: trwalke <trwalke@microsoft.com>
  • Loading branch information
trwalke and trwalke authored Apr 5, 2024
1 parent 72a4388 commit 9a576f7
Show file tree
Hide file tree
Showing 8 changed files with 15 additions and 15 deletions.
2 changes: 1 addition & 1 deletion benchmark/Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
</PropertyGroup>

<PropertyGroup Label="Common dependency versions">
<MicrosoftIdentityLabApiVersion>0.12.1</MicrosoftIdentityLabApiVersion>
<MicrosoftIdentityLabApiVersion>0.12.2</MicrosoftIdentityLabApiVersion>
<BenchmarkDotNetVersion>0.13.12</BenchmarkDotNetVersion>
<BenchmarkDotNetDiagnosticsWindowsVersion>0.13.12</BenchmarkDotNetDiagnosticsWindowsVersion>
</PropertyGroup>
Expand Down
10 changes: 5 additions & 5 deletions build/template-install-dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,14 @@ steps:
# Install all secrets needed from KeyVault onto the build machine.

- task: AzureKeyVault@1
displayName: 'Azure Key Vault: buildautomation'
displayName: 'Azure Key Vault: msidlabs'
inputs:
azureSubscription: '.NET Keyvault'
KeyVaultName: buildautomation
SecretsFilter: 'AzureADIdentityDivisionTestAgentCert'
azureSubscription: 'AuthSdkResourceManager'
KeyVaultName: 'msidlabs'
SecretsFilter: 'LabVaultAccessCert'

- powershell: |
$kvSecretBytes = [System.Convert]::FromBase64String('$(AzureADIdentityDivisionTestAgentCert)')
$kvSecretBytes = [System.Convert]::FromBase64String('$(LabVaultAccessCert)')
$certCollection = New-Object System.Security.Cryptography.X509Certificates.X509Certificate2Collection
$certCollection.Import($kvSecretBytes, $null, [System.Security.Cryptography.X509Certificates.X509KeyStorageFlags]::Exportable)
Expand Down
2 changes: 1 addition & 1 deletion tests/Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
<!--CVE-2021-24112-->
<SystemDrawingCommonVersion>5.0.3</SystemDrawingCommonVersion>
<SystemManagementVersion>8.0.0</SystemManagementVersion>
<MicrosoftIdentityLabApiVersion>0.12.1</MicrosoftIdentityLabApiVersion>
<MicrosoftIdentityLabApiVersion>0.12.2</MicrosoftIdentityLabApiVersion>
</PropertyGroup>

<PropertyGroup Condition="'$(TF_BUILD)' == 'true'">
Expand Down
8 changes: 4 additions & 4 deletions tests/Microsoft.Identity.Web.Test.Common/TestConstants.cs
Original file line number Diff line number Diff line change
Expand Up @@ -104,15 +104,15 @@ public static class TestConstants

// Constants for the lab
public const string OBOClientKeyVaultUri = "TodoListServiceV2-OBO";
public const string ConfidentialClientKeyVaultUri = "https://buildautomation.vault.azure.net/secrets/AzureADIdentityDivisionTestAgentSecret/";
public const string ConfidentialClientId = "16dab2ba-145d-4b1b-8569-bf4b9aed4dc8";
public const string ConfidentialClientKeyVaultUri = "https://msidlabs.vault.azure.net/secrets/LabVaultAccessCert/";
public const string ConfidentialClientId = "f62c5ae3-bf3a-4af5-afa8-a68b800396e9";
public const string ConfidentialClientLabTenant = "72f988bf-86f1-41af-91ab-2d7cd011db47";
public const string OBOUser = "fIDLAB@msidlab4.com";
public const string OBOClientSideClientId = "c0485386-1e9a-4663-bc96-7ab30656de7f";
public static string[] s_oBOApiScope = new string[] { "api://f4aa5217-e87c-42b2-82af-5624dd14ee72/.default" };
public const string LabClientId = "16dab2ba-145d-4b1b-8569-bf4b9aed4dc8";
public const string LabClientId = "f62c5ae3-bf3a-4af5-afa8-a68b800396e9";
public const string MSIDLabLabKeyVaultName = "https://msidlabs.vault.azure.net";
public const string AzureADIdentityDivisionTestAgentSecret = "AzureADIdentityDivisionTestAgentSecret";
public const string AzureADIdentityDivisionTestAgentSecret = "MSIDLABAccessSecret";
public const string BuildAutomationKeyVaultName = "https://buildautomation.vault.azure.net/";
public const string LabVaultAppId = "LabVaultAppID";
public const string LabVaultAppSecret = "LabVaultAppSecret";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

<ItemGroup>
<PackageReference Include="BenchmarkDotNet" Version="0.13.8" />
<PackageReference Include="Microsoft.Identity.Lab.Api" Version="0.12.1" />
<PackageReference Include="Microsoft.Identity.Lab.Api" Version="0.12.2" />

</ItemGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

<ItemGroup>
<PackageReference Include="BenchmarkDotNet" Version="0.13.8" />
<PackageReference Include="Microsoft.Identity.Lab.Api" Version="0.12.1" />
<PackageReference Include="Microsoft.Identity.Lab.Api" Version="0.12.2" />
</ItemGroup>

<ItemGroup Condition="'$(UseWilson7)' == 'true'">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Identity.Lab.Api" Version="0.12.1" />
<PackageReference Include="Microsoft.Identity.Lab.Api" Version="0.12.2" />
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Identity.Lab.Api" Version="0.12.1" />
<PackageReference Include="Microsoft.Identity.Lab.Api" Version="0.12.2" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.6.0" />
<PackageReference Include="xunit" Version="2.4.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
Expand Down

0 comments on commit 9a576f7

Please sign in to comment.