Making GetClientAssertion method public (#2112)

* Making GetClientAssertion abstract method and its implementations public to support inheritance of ClientAssertionProviderBase.
AzureAD · Mar 17, 2023 · 9c1a60a · 9c1a60a
1 parent 5475d1e
commit 9c1a60a
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/Microsoft.Identity.Web.Certificateless/AzureIdentityForKubernetesClientAssertion.cs b/src/Microsoft.Identity.Web.Certificateless/AzureIdentityForKubernetesClientAssertion.cs
@@ -42,7 +42,7 @@ public AzureIdentityForKubernetesClientAssertion(string? filePath)
         /// Get the signed assertion from a file.
         /// </summary>
         /// <returns>The signed assertion.</returns>
-        internal override Task<ClientAssertion> GetClientAssertion(CancellationToken cancellationToken)
+        public override Task<ClientAssertion> GetClientAssertion(CancellationToken cancellationToken)
         {
             string signedAssertion = File.ReadAllText(_filePath);
             // Compute the expiry

diff --git a/src/Microsoft.Identity.Web.Certificateless/ClientAssertionProviderBase.cs b/src/Microsoft.Identity.Web.Certificateless/ClientAssertionProviderBase.cs
@@ -18,7 +18,7 @@ public abstract class ClientAssertionProviderBase
         /// </summary>
         /// <param name="cancellationToken"></param>
         /// <returns></returns>
-        internal abstract Task<ClientAssertion> GetClientAssertion(CancellationToken cancellationToken);
+        public abstract Task<ClientAssertion> GetClientAssertion(CancellationToken cancellationToken);
 
         /// <summary>
         /// Client assertion.

diff --git a/src/Microsoft.Identity.Web.Certificateless/ManagedIdentityClientAssertion.cs b/src/Microsoft.Identity.Web.Certificateless/ManagedIdentityClientAssertion.cs
@@ -29,7 +29,7 @@ public ManagedIdentityClientAssertion(string? managedIdentityClientId)
         /// acquired with managed identity (certificateless).
         /// </summary>
         /// <returns>The signed assertion.</returns>
-        internal override async Task<ClientAssertion> GetClientAssertion(CancellationToken cancellationToken)
+        public override async Task<ClientAssertion> GetClientAssertion(CancellationToken cancellationToken)
         {
             var credential = new DefaultAzureCredential(new DefaultAzureCredentialOptions { ManagedIdentityClientId = _managedIdentityClientId });
 

diff --git a/tests/Microsoft.Identity.Web.Test/ClientAssertionTests.cs b/tests/Microsoft.Identity.Web.Test/ClientAssertionTests.cs
@@ -13,7 +13,7 @@ public class TestClientAssertion : ClientAssertionProviderBase
     {
         private int _n = 0;
 
-        internal override Task<ClientAssertion> GetClientAssertion(CancellationToken cancellationToken)
+        public override Task<ClientAssertion> GetClientAssertion(CancellationToken cancellationToken)
         {
             _n++;
             return Task.FromResult(new ClientAssertion(