Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Add a SendX5c option to help certificate rotation (1P) #197

Closed
jmprieur opened this issue Jun 10, 2020 · 1 comment
Closed

[Feature Request] Add a SendX5c option to help certificate rotation (1P) #197

jmprieur opened this issue Jun 10, 2020 · 1 comment
Assignees
@jennyf19
Labels
enhancement New feature or request fixed good first issue Good for newcomers scenario: azure
Milestone
0.1.5-preview

Comments

@jmprieur
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
MSAL.NET provides an option to send the x5c with the certificate to help certificate rotation (.WithX5c(true)), but Microsoft.Identity.Web does not expose it.

Describe the solution you'd like

  • MicrosoftIdentityOptions has a new boolean property sendX5c
  • When calling .WithCertificate on the confidential client application, TokenAcquisition also adds a call to .WithSendX5C(microsoftIdentityOptions.sendX5c)

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.
@jmprieur jmprieur added enhancement New feature or request scenario: azure good first issue Good for newcomers labels Jun 10, 2020
@jmprieur jmprieur added this to the 0.1.5-preview milestone Jun 10, 2020
@jennyf19 jennyf19 mentioned this issue Jun 11, 2020
Merged
@pmaytak
Copy link
Contributor

pmaytak commented Jun 16, 2020

Included in Microsoft Identity Web 0.1.5-preview release.

@pmaytak pmaytak closed this as completed Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jennyf19 jennyf19

Labels
enhancement New feature or request fixed good first issue Good for newcomers scenario: azure
Projects
None yet
Milestone
0.1.5-preview
Development

No branches or pull requests
3 participants
@jmprieur @jennyf19 @pmaytak