Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jennyf/x5c #200

Merged
merged 3 commits into from
Jun 11, 2020
Merged

Jennyf/x5c #200

merged 3 commits into from
Jun 11, 2020

Conversation

jennyf19
Copy link
Collaborator

#197

@jmprieur please review xml comment. copied from msal.

@jennyf19 jennyf19 requested a review from jmprieur June 11, 2020 18:39

/// <summary>
/// Specifies if the x5c claim (public key of the certificate) should be sent to the STS.
/// Sending the x5c enables application developers to achieve easy certificate roll-over in Azure AD:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Sending the x5c enables application developers to achieve easy certificate roll-over in Azure AD:
/// Sending the x5c enables application developers to achieve easy certificate rollover in Azure AD:

/// this method will send the public certificate to Azure AD along with the token request,
/// so that Azure AD can use it to validate the subject name based on a trusted issuer policy.
/// This saves the application admin from the need to explicitly manage the certificate rollover
/// (either via portal or powershell/CLI operation). For details see https://aka.ms/msal-net-sni.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// (either via portal or powershell/CLI operation). For details see https://aka.ms/msal-net-sni.
/// (either via portal or PowerShell/CLI operation). For details see https://aka.ms/msal-net-sni.

@jennyf19 jennyf19 merged commit 07ab430 into master Jun 11, 2020
@jennyf19 jennyf19 deleted the jennyf/x5c branch June 11, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants