Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Daemon applications do not require a redirectUri but it's required in TokenAcquisition #38

Closed
jennyf19 opened this issue Feb 26, 2020 · 1 comment
Closed

[Bug] Daemon applications do not require a redirectUri but it's required in TokenAcquisition #38

jennyf19 opened this issue Feb 26, 2020 · 1 comment
Labels
bug Something isn't working fixed improved-devex investigate scenario: daemon
Milestone
[2] .NET5 preview 8

Comments

@jennyf19
Copy link
Collaborator

jennyf19 commented Feb 26, 2020 •
edited
Loading

In TokenAcquisition, the redirect uri is calculated if the cc application is created there. However, when creating a Daemon application and using the ConfidentialClientApplicationOptions, the redirectUri is not required, so TokenAcquisition calculates a redirecturi which is not registered or needed, and MS Identity Web currently throws a null ref here.
@jennyf19 jennyf19 mentioned this issue Feb 28, 2020
Merged
jmprieur added a commit that referenced this issue Jul 15, 2020
@jmprieur
Related to:
12fc385 
- #248
- #38
@jmprieur jmprieur mentioned this issue Jul 15, 2020
Closed
@jennyf19 jennyf19 mentioned this issue Jul 19, 2020
Merged
jennyf19 added a commit that referenced this issue Jul 20, 2020
@jennyf19 @jmprieur
Jennyf/http investigation (#339)
1c5add4 
* Related to:
- #248
- #38

* fix build warnings (#325)

* update xml

Co-authored-by: Jean-Marc Prieur <jmprieur@microsoft.com>
@pmaytak pmaytak added this to the [2] .NET5 preview 8 milestone Jul 24, 2020
@pmaytak pmaytak added fixed and removed In progress labels Jul 24, 2020
@pmaytak
Copy link
Contributor

pmaytak commented Jul 25, 2020

This is included in Microsoft Identity Web 0.2.1-preview release.

@pmaytak pmaytak closed this as completed Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working fixed improved-devex investigate scenario: daemon
Projects
None yet
Milestone
[2] .NET5 preview 8
Development

No branches or pull requests
3 participants
@jmprieur @jennyf19 @pmaytak