Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support authentication scheme in all scenarios #955

Closed
jmprieur opened this issue Feb 11, 2021 · 4 comments
Closed

[Feature Request] Support authentication scheme in all scenarios #955

jmprieur opened this issue Feb 11, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request fixed multiple auth schemes supported in v.1.10 P2
Milestone

Comments

@jmprieur
Copy link
Collaborator

jmprieur commented Feb 11, 2021

Which version of Microsoft Identity Web are you using?
4.16.0

Repro

Customers need to be able to implement apps which sign-in users with AAD and B2C, or which are web apps and web APIs. Today, the authentication scheme are supposed to help for this, but they are not taken into account everywhere.

See:

This issue might be related:

Expected behavior
A fully functional sample of an AAD + B2C web app which also contains web APIS.

Actual behavior
See the referenced issues for repro steps

Possible solution
See investigation in branch https://github.com/AzureAD/microsoft-identity-web/tree/jmprieur/multipleSchemeInvestigation

@jennyf19
Copy link
Collaborator

@jmprieur we need to test the confidential client options, i had issues w/the unit tests and had to add Instance and clientSecret. just adding this as a reminder.

@jennyf19 jennyf19 self-assigned this Apr 22, 2021
@jennyf19 jennyf19 changed the title [Bug] Support authentication scheme in all scenarios [Feature Request] Support authentication scheme in all scenarios Apr 22, 2021
@jennyf19 jennyf19 added enhancement New feature or request and removed bug Something isn't working investigating labels Apr 22, 2021
@jennyf19
Copy link
Collaborator

jennyf19 commented Apr 29, 2021

TODO:

@jmprieur
Copy link
Collaborator Author

jmprieur commented May 1, 2021

For Microsoft Graph, I wonder if we need to add a method so that controller actions which are called for a specific auth scheme can pass it, in to the Graph SDK, like we do here to override the scopes

or the app-only characteristics:

BaseRequestExtensions.WithAuthenticationScheme<T>(this T baseRequest, string authenticationScheme)

This would have an impact in the Microsoft.Identity.Web.MicrosoftGraph assembly on:

  • TokenAcquisitionAuthenticationProviderOption (new AuthenticationScheme property)
  • TokenAcquisitionAuthenticationProvider adding an authenticationScheme member, and passing it through to the token acquisition methods (which now have it as a parameter)

@jennyf19 jennyf19 added the multiple auth schemes supported in v.1.10 label May 5, 2021
@jennyf19
Copy link
Collaborator

Included in 1.11.0 release and documentation here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed multiple auth schemes supported in v.1.10 P2
Projects
None yet
Development

No branches or pull requests

2 participants