make cca creation not async #1085
Conversation
| @@ -421,6 +417,8 @@ public async Task ReplyForbiddenWithWwwAuthenticateHeaderAsync(IEnumerable<strin | |||
| httpResponse.StatusCode = (int)HttpStatusCode.Forbidden; | |||
|
|
|||
| headers[HeaderNames.WWWAuthenticate] = new StringValues($"{Constants.Bearer} {parameterString}"); | |||
|
|
|||
| await Task.CompletedTask.ConfigureAwait(false); // we don't want to take a breaking change right now. will be for 2.0 | |||
There was a problem hiding this comment.
This is one of those cases where the task should be returned instead of awaited. #Resolved
There was a problem hiding this comment.
yes...i talked w/ @jmprieur about this one and we are going to wait until we move to 2.* and take a breaking change. so this will come soon. #Resolved
| @@ -17,8 +17,7 @@ public abstract class MsalAbstractTokenCacheProvider : IMsalTokenCacheProvider | |||
| /// Initializes the token cache serialization. | |||
| /// </summary> | |||
| /// <param name="tokenCache">Token cache to serialize/deserialize.</param> | |||
| /// <returns>A <see cref="Task"/> that represents a completed initialization operation.</returns> | |||
| public Task InitializeAsync(ITokenCache tokenCache) | |||
| public void Initialize(ITokenCache tokenCache) | |||
There was a problem hiding this comment.
This is technically a breaking change. Is there anything special you need to do to rev the library version? #Resolved
There was a problem hiding this comment.
we are going w/henrik's suggestion and doing obsolete attributes so we don't have to take a major version right now. #Resolved
|
We could start by deprecating and pointing to the updated functions? #Resolved |
|
yes...good idea, i've fixed that. In reply to: 806008756 [](ancestors = 806008756) |
I'm just fixing this cca async issue, which will enable david to remove some code, i'm not going to work on something from that PR specifically. In reply to: 806012208 [](ancestors = 806012208) Refers to: src/Microsoft.Identity.Web/TokenAcquisition.cs:36 in 1281902. [](commit_id = 1281902, deletion_comment = False) |
|
SonarCloud Quality Gate failed. |
|
@jmprieur I'll make a 2.* project board and start a running list of the breaking changes so we don't forget |
@DavidParks8 thanks for the suggestion of making cca not async. i think this was done back it was a sample and needed for something else...as things moved to MSAL, we were able to remove that functionality out of id web. @jmprieur