add cache extensions #1278
Merged
add cache extensions #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmprieur
approved these changes
Jun 21, 2021
| /// </code> | ||
| /// | ||
| /// </example> | ||
| /// <remarks>Don't use this method in ASP.NET Core. Just add use the ConfigureServices method |
There was a problem hiding this comment.
Maybe add a 'see also' to recommend AddDistributedTokenCaches?
If you are using distributed token caches, is recommanded, or something like that? #Resolved
| /// Add an in-memory well partitioned token cache to MSAL.NET confidential client | ||
| /// application. Don't use this method in ASP.NET Core: rather use: | ||
| /// <code>services.AddInMemoryTokenCaches()</code> in ConfigureServices. | ||
| /// In net462 and net472, you'll need to reference Microsoft.Extensions.Caching.Memory. |
There was a problem hiding this comment.
Actually, I think that we now do in Ms.Id.Web. So we can remove this sentence. #Resolved
| } | ||
|
|
||
| // In memory token cache | ||
| // In net472, requires to reference Microsoft.Extensions.Caching.Memory |
There was a problem hiding this comment.
I guess we can remove this comment #Resolved
|
PR: #1277 |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.