-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1390 #1391
Fixes #1390 #1391
Conversation
@@ -18,6 +20,9 @@ namespace Microsoft.Identity.Web | |||
/// </summary> | |||
public static class TokenCacheExtensions | |||
{ | |||
private static readonly Dictionary<MethodInfo, IServiceProvider> s_serviceProviderFromAction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ConcurrentDictionary is thread safe, Dictionary is not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. #resolve
@@ -2,6 +2,8 @@ | |||
// Licensed under the MIT License. | |||
|
|||
using System; | |||
using System.Collections.Generic; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no unit tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know for the UTs. I just wanted to have a branch for the partner to see if this would unblock them
src/Microsoft.Identity.Web/TokenCacheProviders/TokenCacheExtensions.cs
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
Fixes #1390
See issue for test