Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1390 #1391

Merged
merged 3 commits into from
Aug 18, 2021
Merged

Fixes #1390 #1391

merged 3 commits into from
Aug 18, 2021

Conversation

jmprieur
Copy link
Collaborator

@jmprieur jmprieur commented Aug 17, 2021

Fixes #1390

See issue for test

@jmprieur jmprieur requested a review from jennyf19 August 17, 2021 15:47
@@ -18,6 +20,9 @@ namespace Microsoft.Identity.Web
/// </summary>
public static class TokenCacheExtensions
{
private static readonly Dictionary<MethodInfo, IServiceProvider> s_serviceProviderFromAction
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ConcurrentDictionary is thread safe, Dictionary is not.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. #resolve

@@ -2,6 +2,8 @@
// Licensed under the MIT License.

using System;
using System.Collections.Generic;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no unit tests

Copy link
Collaborator Author

@jmprieur jmprieur Aug 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know for the UTs. I just wanted to have a branch for the partner to see if this would unblock them

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@jennyf19 jennyf19 merged commit bd087e1 into master Aug 18, 2021
@jennyf19 jennyf19 deleted the Fix1390 branch August 18, 2021 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] In .Net framework, when recreating the CCA each time one wants to acquire a token, the cache is not hit
3 participants