Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Base64UrlHelpers #1433

Merged
merged 1 commit into from
Sep 24, 2021
Merged

Optimize Base64UrlHelpers #1433

merged 1 commit into from
Sep 24, 2021

Conversation

bgavrilMS
Copy link
Member

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

87.8% 87.8% Coverage
0.0% 0.0% Duplication

jennyf19
jennyf19 approved these changes Sep 9, 2021
View reviewed changes
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bgavrilMS appreciate it. was going to do it, as i saw the PR in msal. thanks. not sure when i'll merge it...either before or after the splitting.

jmprieur
jmprieur approved these changes Sep 9, 2021
View reviewed changes
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bgavrilMS

@bgavrilMS
Copy link
Member Author

@jennyf19 - I'll let you merge this one so as not to cause conflicts with your other work.

@jennyf19 jennyf19 merged commit 4feafe3 into master Sep 24, 2021
@jennyf19 jennyf19 deleted the bogavril/base64url branch September 24, 2021 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennyf19 jennyf19 jennyf19 approved these changes

@jmprieur jmprieur jmprieur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgavrilMS @jmprieur @jennyf19