Initial version to support OWIN, .NET, .NET Core #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs a few updates to unit tests
- AddTokenAcquisition now callable from net462 - AddGraph calllable from net462 - Adding a daemon sample using Id.Web.
- AddTokenAcquisition now callable from net462 - AddGraph calllable from net462 - Adding a daemon sample using Id.Web.
bgavrilMS
reviewed
Mar 17, 2022
bgavrilMS
reviewed
Mar 17, 2022
bgavrilMS
reviewed
Mar 17, 2022
|
|
||
| namespace Microsoft.Identity.Web.Hosts | ||
| { | ||
| internal class PlainDotNetTokenAcquisitionHost : ITokenAcquisitionHost |
There was a problem hiding this comment.
Maybe DefaultTokenAcquisitionHost or NullTokenAcquisitionHost
bgavrilMS
reviewed
Mar 17, 2022
src/Microsoft.Identity.Web/Hosts/PlainDotNet/PlainDotNetTokenAcquisitionHost.cs
Outdated
Show resolved
Hide resolved
Microsoft.Identity.Web.TokenAcquisition.Abstractions
jmprieur
changed the title
…reAd/microsoft-identity-web into jmprieur/Sandbox-FutureDevEx
…or specifying "OpendIdConnect" as an auth scheme, which didn't make sense. - Fixing MergeOptions.Instance (was not set) - Addressing PR feedback - Adding missing XML comments - Updaring tests now that there is a new interface (ITokenAcquirer)
Moving types from Id.Web to the new assembly CONS: - a lot of friend relationships. - some constants should be split between id.web.tokenacquisition and Id.Web
* update new dlls with directory.build.props * Updating the Web.Config assembly bindings in the ASP.NET OWIN Web app * Updating the folder name for the daemon app * PR feedback Co-authored-by: Jean-Marc Prieur <jmprieur@microsoft.com>
…d.Web) (#1810) * - In AuthenticationOptions and MicrosoftAuthenticationOptions, move properties were they should have been in the first place (when AAD specific) - Move LoggingOptions to Ms.Id.Web.TokenAcquisition - MicrosoftIdentityBaseAuthenticationBuilder and MicrosoftIdentityAppCallingWebApiAuthenticationBuilder move to Ms.Id.Web.TokenAcquisition - Session methods of MicrosoftIdentityAppCallingWebApiAuthenticationBuilder move to an extension method - TokenAcquisitionAspNetCore inherits from TokenAcquisition instead of being a partial class implementation (Could move to another assembly if we choose to) - AddTokenAcquisition now register ITokenAcquirer (And only this one in the case of framework others than .NET Core) * - OwinWebApi now is 472 - OwinWebApp updates to Web.Config and project - Ms.Id.Web.MicrosoftGraph now references Ms.Id.Web.TokenAcquisition (no longer Ms.Id.Web) * PR review * Adressing PR comment
jennyf19
reviewed
Jul 19, 2022
jennyf19
reviewed
Jul 19, 2022
jennyf19
reviewed
Jul 19, 2022
...t.Identity.Web/WebAppExtensions/MicrosoftIdentityAppCallingWebApiAuthenticationBuilderExt.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Jul 19, 2022
src/Microsoft.Identity.Web/WebAppExtensions/MicrosoftIdentityWebAppAuthenticationBuilder.cs
Show resolved
Hide resolved
jennyf19
reviewed
Jul 19, 2022
src/Microsoft.Identity.Web.MicrosoftGraph/Microsoft.Identity.Web.MicrosoftGraph.csproj
Show resolved
Hide resolved
jennyf19
reviewed
Jul 19, 2022
jennyf19
reviewed
Jul 19, 2022
jennyf19
reviewed
Jul 19, 2022
jennyf19
reviewed
Jul 19, 2022
jennyf19
reviewed
Jul 19, 2022
jennyf19
reviewed
Jul 19, 2022
src/Microsoft.Identity.Web.TokenAcquisition/PlainDotNetTokenAcquisitionHost.cs
Outdated
Show resolved
Hide resolved
|
I'm only partway through. I will the branch and continue tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments to add - not ready to review
Needs a few updates to unit tests
Not ready to review
There are a lot of files changed, but this is mainly because of the new OWIN sample