Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use scoped and not singleton for service #1759

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Use scoped and not singleton for service #1759

merged 1 commit into from
Jun 15, 2022

Conversation

jennyf19
Copy link
Collaborator

@jennyf19 jennyf19 requested a review from jmprieur June 15, 2022 01:46
jmprieur
jmprieur approved these changes Jun 15, 2022
View reviewed changes
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @jennyf19

@jennyf19
Copy link
Collaborator Author

@jmprieur have tested w/affected sample.

@jennyf19 jennyf19 merged commit aff603c into master Jun 15, 2022
@jennyf19 jennyf19 deleted the jennyf/1757 branch June 15, 2022 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmprieur jmprieur jmprieur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennyf19 @jmprieur