Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix #749 Claim Actions Missing & Not Running #1899

Merged
merged 2 commits into from
Oct 24, 2022
Merged

Bugfix #749 Claim Actions Missing & Not Running #1899

merged 2 commits into from
Oct 24, 2022

Conversation

warrenbuckley
Copy link

Hello 👋 @jennyf19
I believe this PR will fix the following issue #749 where ClaimActions are not run if you alter these when setting up Microsoft.Identity.Web in configuration/options.

I have unable to test this easily with my own code project, but with ClaimActions totally missing in the MergedOptions class I would believe this is the problem that myself and others are having.

Look forward to your feedback and input

Thanks,
Warren :)

@warrenbuckley
Copy link
Author

Is anyone from this team/repo likely to consider or comment on this PR, as I feel like I am in limbo with this.
Pinging the two people I can see making commits or comments in PRs in the hope I can get some input or feedback @jennyf19 & @pmaytak

Thanks,
Warren 😄

jmprieur
jmprieur approved these changes Oct 23, 2022
View reviewed changes
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @warrenbuckley

@jennyf19. We can merge to master, and also take in rel/v2.

@jennyf19
Copy link
Collaborator

Thanks @warrenbuckley - will take a look at this today. Thanks for your patience!

@jennyf19 jennyf19 changed the base branch from master to jennyf/claim-actions October 24, 2022 20:47
@jennyf19 jennyf19 merged commit 9d72bf7 into AzureAD:jennyf/claim-actions Oct 24, 2022
jennyf19 added a commit that referenced this pull request Oct 24, 2022
@jennyf19
Bugfix #749 Claim Actions Missing & Not Running (#1899) (#1930)
bd81458 
* Add in missing ClaimActions into MergedOptions

* Add unit test to verify that the merged option for ClaimAction will appear

Co-authored-by: Warren Buckley <warren@umbraco.com>
@warrenbuckley
Copy link
Author

Thanks @jennyf19 & @jmprieur its good to know that this has been merged in.
Do you know when and what version my fix will be in?

Would it be possible for this PR to be marked as part of my Hacktoberfest contribution please?
Reading the site, it seems you as maintainers would need to add a label of HACKTOBERFEST-ACCEPTED to this PR

@warrenbuckley warrenbuckley deleted the bugfix/claim-actions branch October 25, 2022 07:29
@jennyf19
Copy link
Collaborator

jennyf19 commented Oct 25, 2022 •
edited
Loading

That's awesome! I've added the label. We will probably do a release of 2.0.4-preview this week and the fix will be there.

@jennyf19 jennyf19 added this to the 2.0.4-preview milestone Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmprieur jmprieur jmprieur approved these changes

Assignees

@warrenbuckley warrenbuckley

Labels
HACKTOBERFEST-ACCEPTED
Projects
None yet
Milestone
2.0.4-preview
Development

Successfully merging this pull request may close these issues.
3 participants
@warrenbuckley @jennyf19 @jmprieur