Jennyf/update lab #190
Merged
Jennyf/update lab #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixing bugs in CertificateDescription (discovered by tests)
jennyf19
force-pushed
the
jennyf/updateLab
branch
from
7c02ac6 to
c621305
Compare
jmprieur
approved these changes
Jun 7, 2020
There was a problem hiding this comment.
Awesome, @jennyf19.
As you know I tried a client certificate instead of a client secret for the web app and this works.
I've left a few suggestions for improvement, but LGTM.
I know many partners who are going to love this feature.
src/Microsoft.Identity.Web/CertificateManagement/CertificateDescription.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Identity.Web/CertificateManagement/CertificateDescription.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Identity.Web/CertificateManagement/CertificateDescription.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Identity.Web/CertificateManagement/DefaultCertificateLoader.cs
Show resolved
Hide resolved
tests/Microsoft.Identity.Web.Test/Certificates/CertificatesTests.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Web.Test/Certificates/DefaultCertificateLoaderTests.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Web.Test/Certificates/DefaultCertificateLoaderTests.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Web.Test/Certificates/DefaultCertificateLoaderTests.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Web.Test/Certificates/DefaultCertificateLoaderTests.cs
Outdated
Show resolved
Hide resolved
|
thanks @jmprieur you are too fast, this is not ready for review yet, which is why it's marked as "draft". I mainly made the PR to see which tests would fail. thanks again. #Resolved |
|
oh sorry, @jennyf19. I got excited too quickly. |
jennyf19
force-pushed
the
jennyf/updateLab
branch
from
7f0cf32 to
5295761
Compare
add cert option in dev app add decrypt cert
jennyf19
force-pushed
the
jennyf/updateLab
branch
from
1b9c912 to
24d47dc
Compare
- Removing unused parameter - committing the XML doc files
pmaytak
requested changes
Jun 9, 2020
src/Microsoft.Identity.Web/CertificateManagement/CertificateDescription.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Identity.Web/CertificateManagement/CertificateDescription.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Identity.Web/CertificateManagement/DefaultCertificateLoader.cs
Show resolved
Hide resolved
src/Microsoft.Identity.Web/CertificateManagement/DefaultCertificateLoader.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Identity.Web/MicrosoftIdentityOptionsValidation.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Identity.Web/MicrosoftIdentityOptionsValidation.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Web.Test/Certificates/CertificateDescriptionTests.cs
Outdated
Show resolved
Hide resolved
Add unit tests for new format of cert description
pmaytak
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.